From 9c5d31163f285a7c6f59308f61b8320ce8425e86 Mon Sep 17 00:00:00 2001 From: Jimmy Lai Date: Sun, 8 Feb 2026 10:26:37 -0800 Subject: [PATCH] [Flight] Fix debug channel flag in Node.js server renderToPipeableStream The `createRequest` call in `renderToPipeableStream` was passing `debugChannel !== undefined` instead of `debugChannelReadable !== undefined` in the turbopack, esm, and parcel server implementations. The webpack version already had the correct check. This could cause the server to emit debug info even when only a write-only debug channel is provided with no readable side, potentially causing the client to block forever waiting for debug data. Co-Authored-By: Claude Opus 4.6 --- .../react-server-dom-esm/src/server/ReactFlightDOMServerNode.js | 2 +- .../src/server/ReactFlightDOMServerNode.js | 2 +- .../src/server/ReactFlightDOMServerNode.js | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/react-server-dom-esm/src/server/ReactFlightDOMServerNode.js b/packages/react-server-dom-esm/src/server/ReactFlightDOMServerNode.js index 9c167223bacc..a4bda173f158 100644 --- a/packages/react-server-dom-esm/src/server/ReactFlightDOMServerNode.js +++ b/packages/react-server-dom-esm/src/server/ReactFlightDOMServerNode.js @@ -187,7 +187,7 @@ function renderToPipeableStream( options ? options.startTime : undefined, __DEV__ && options ? options.environmentName : undefined, __DEV__ && options ? options.filterStackFrame : undefined, - debugChannel !== undefined, + debugChannelReadable !== undefined, ); let hasStartedFlowing = false; startWork(request); diff --git a/packages/react-server-dom-parcel/src/server/ReactFlightDOMServerNode.js b/packages/react-server-dom-parcel/src/server/ReactFlightDOMServerNode.js index 910561aca51a..d267edd085af 100644 --- a/packages/react-server-dom-parcel/src/server/ReactFlightDOMServerNode.js +++ b/packages/react-server-dom-parcel/src/server/ReactFlightDOMServerNode.js @@ -199,7 +199,7 @@ export function renderToPipeableStream( options ? options.startTime : undefined, __DEV__ && options ? options.environmentName : undefined, __DEV__ && options ? options.filterStackFrame : undefined, - debugChannel !== undefined, + debugChannelReadable !== undefined, ); let hasStartedFlowing = false; startWork(request); diff --git a/packages/react-server-dom-turbopack/src/server/ReactFlightDOMServerNode.js b/packages/react-server-dom-turbopack/src/server/ReactFlightDOMServerNode.js index 1590aa6a37c9..5381072b3ad8 100644 --- a/packages/react-server-dom-turbopack/src/server/ReactFlightDOMServerNode.js +++ b/packages/react-server-dom-turbopack/src/server/ReactFlightDOMServerNode.js @@ -193,7 +193,7 @@ function renderToPipeableStream( options ? options.startTime : undefined, __DEV__ && options ? options.environmentName : undefined, __DEV__ && options ? options.filterStackFrame : undefined, - debugChannel !== undefined, + debugChannelReadable !== undefined, ); let hasStartedFlowing = false; startWork(request);