From c9ea893429f11223cd95fad45b9d1060d766b9a6 Mon Sep 17 00:00:00 2001 From: An Vu Date: Thu, 4 Apr 2024 17:56:40 +1030 Subject: [PATCH 1/2] fix failing spec --- spec/lib/fat_zebra/utilities/apple_pay/domain_spec.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spec/lib/fat_zebra/utilities/apple_pay/domain_spec.rb b/spec/lib/fat_zebra/utilities/apple_pay/domain_spec.rb index 253b4c4..4fe3ba3 100644 --- a/spec/lib/fat_zebra/utilities/apple_pay/domain_spec.rb +++ b/spec/lib/fat_zebra/utilities/apple_pay/domain_spec.rb @@ -28,7 +28,7 @@ let!(:domain) { "www.example99.com" } let!(:valid_payload) {{ - async: false + 'async' => false }} it "creates the domain" do From 1c015d33221369dd3ebe32dc51273f689e26b48a Mon Sep 17 00:00:00 2001 From: An Vu Date: Mon, 8 Apr 2024 10:24:11 +0930 Subject: [PATCH 2/2] change options arg to be positional rather than keyword --- lib/fat_zebra/utilities/apple_pay/domain.rb | 8 ++++---- spec/lib/fat_zebra/utilities/apple_pay/domain_spec.rb | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/fat_zebra/utilities/apple_pay/domain.rb b/lib/fat_zebra/utilities/apple_pay/domain.rb index d5d74a9..c82457c 100644 --- a/lib/fat_zebra/utilities/apple_pay/domain.rb +++ b/lib/fat_zebra/utilities/apple_pay/domain.rb @@ -15,7 +15,7 @@ class << self # @param [Hash] options for the request, and configurations (Optional) # # @return [FatZebra::Utilities::ApplePay::Domains] response - def list(options: {}) + def list(options = {}) params = {} response = request(:get, ENDPOINT_URL, params, options) initialize_from(response) @@ -29,7 +29,7 @@ def list(options: {}) # @param [Hash] options for the request, and configurations (Optional) # # @return [FatZebra::Utilities::ApplePay::Domains] response - def register!(domain, params = {}, options: {}) + def register!(domain, params = {}, options = {}) response = request(:post, path(domain), params, options) initialize_from(response) end @@ -41,7 +41,7 @@ def register!(domain, params = {}, options: {}) # @param [Hash] options for the request, and configurations (Optional) # # @return [FatZebra::Utilities::ApplePay::Domains] response - def find!(domain, options: {}) + def find!(domain, options = {}) params = {} response = request(:get, path(domain), params, options) initialize_from(response) @@ -54,7 +54,7 @@ def find!(domain, options: {}) # @param [Hash] options for the request, and configurations (Optional) # # @return [FatZebra::Utilities::ApplePay::Domains] response - def delete!(domain, options: {}) + def delete!(domain, options = {}) params = {} response = request(:delete, path(domain), params, options) initialize_from(response) diff --git a/spec/lib/fat_zebra/utilities/apple_pay/domain_spec.rb b/spec/lib/fat_zebra/utilities/apple_pay/domain_spec.rb index 4fe3ba3..253b4c4 100644 --- a/spec/lib/fat_zebra/utilities/apple_pay/domain_spec.rb +++ b/spec/lib/fat_zebra/utilities/apple_pay/domain_spec.rb @@ -28,7 +28,7 @@ let!(:domain) { "www.example99.com" } let!(:valid_payload) {{ - 'async' => false + async: false }} it "creates the domain" do