build: Remove --experimental-wasm-bulk-memory flag #328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The --experimental-wasm-bulk-memory is no longer supported by Chrome
Collaborator
|
Thanks for the PR! |
jeromewu
added a commit
that referenced
this pull request
Aug 10, 2023
…flag build: Remove --experimental-wasm-bulk-memory flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
--experimental-wasm-bulk-memoryis no longer supported by Chrome.Running this repo locally against
Chrome Version 98.0.4758.80 (Official Build) (arm64), I'm able to run the unit tests without this flag.With the flag in place, the tests exit early with an error message.
With the flag removed, the tests exit happily.