From a1d03bcc5463e8a500232f8ab7572fcf40c101d2 Mon Sep 17 00:00:00 2001 From: Thomas Cooper Date: Tue, 30 Jan 2024 13:11:27 -0500 Subject: [PATCH 1/2] fix: more permission into workflow --- .github/workflows/nodejs.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml index 698fcb169..911fabbd0 100644 --- a/.github/workflows/nodejs.yml +++ b/.github/workflows/nodejs.yml @@ -9,6 +9,9 @@ on: pull_request: branches: [ main ] +permissions: + pull-requests: write + jobs: build: @@ -19,9 +22,6 @@ jobs: node-version: [18.x] mongodb-version: [4.4] - permissions: - pull-requests: write - steps: - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4 with: From fc86cf4a172a0becbdab105d5f557912179f9de6 Mon Sep 17 00:00:00 2001 From: Thomas Cooper Date: Tue, 30 Jan 2024 13:47:46 -0500 Subject: [PATCH 2/2] feat: test codecov trying out the codecov action pin to latest 3.x version feat: commit to trigger coverage report --- .github/workflows/nodejs.yml | 15 ++++----------- src/db/index.js | 1 + 2 files changed, 5 insertions(+), 11 deletions(-) diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml index 911fabbd0..943def7ab 100644 --- a/.github/workflows/nodejs.yml +++ b/.github/workflows/nodejs.yml @@ -56,19 +56,12 @@ jobs: echo "isNotEmpty=false" >> $GITHUB_OUTPUT fi - - name: Install LCOV + - name: Upload test coverage report if: ${{ steps.check-lcov-non-empty.outputs.isNotEmpty == 'true'}} - run: | - sudo apt-get update && sudo apt-get install --assume-yes lcov - - - name: Report code coverage - if: ${{ steps.check-lcov-non-empty.outputs.isNotEmpty == 'true' }} - uses: zgosalvez/github-actions-report-lcov@v4 + uses: codecov/codecov-action@v3.1.5 with: - coverage-files: ./coverage/lcov.info - github-token: ${{ secrets.GITHUB_TOKEN }} - update-comment: true - + files: ./coverage/lcov.info + flags: unittests # - name: Exit if coverage condition not met # if: ${{ steps.test.outputs.exit_code }} != 0 # run: exit ${{ steps.test.outputs.exit_code }} diff --git a/src/db/index.js b/src/db/index.js index 671855ecf..d633f0577 100644 --- a/src/db/index.js +++ b/src/db/index.js @@ -2,6 +2,7 @@ const nodemailer = require('nodemailer'); const generator = require('generate-password'); const passwordHash = require('password-hash'); const validator = require('email-validator'); + const config = require('../config'); if (config.getDatabase().type === 'fs') {