From a8ed069c90190f268a3da9ab0bb19c18dd67cd3d Mon Sep 17 00:00:00 2001 From: Jose Marquez Date: Fri, 25 Aug 2023 09:47:06 -0400 Subject: [PATCH 1/2] Adding explicit children props to components In React 18's types, the implicit children prop on functional components was removed, requiring that it be explicitly defined by developers; this change adds them to the library so that Typescript projects on React 18 can continue to import the library. --- src/index.d.ts | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/index.d.ts b/src/index.d.ts index 4f1e2f1b..5228b32d 100644 --- a/src/index.d.ts +++ b/src/index.d.ts @@ -14,6 +14,7 @@ declare module "@firefox-devtools/react-contextmenu" { preventHideOnResize?: boolean, preventHideOnScroll?: boolean, style?: React.CSSProperties, + children?: React.ReactNode, } export interface ContextMenuTriggerProps { @@ -36,6 +37,7 @@ declare module "@firefox-devtools/react-contextmenu" { divider?: boolean, preventClose?: boolean, onClick?: {(event: React.TouchEvent | React.MouseEvent, data: Object, target: HTMLElement): void} | Function, + children?: React.ReactNode, } export interface SubMenuProps { @@ -46,6 +48,7 @@ declare module "@firefox-devtools/react-contextmenu" { rtl?: boolean, preventCloseOnClick?: boolean, onClick?: {(event: React.TouchEvent | React.MouseEvent, data: Object, target: HTMLElement): void} | Function, + children?: React.ReactNode, } export interface ConnectMenuProps { From 129839ae7952517757eb886c92d4b2078d995d05 Mon Sep 17 00:00:00 2001 From: Jose Marquez Date: Fri, 25 Aug 2023 09:55:34 -0400 Subject: [PATCH 2/2] Also adding children to ContextMenuTriggerProps --- src/index.d.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/index.d.ts b/src/index.d.ts index 5228b32d..6f0c788c 100644 --- a/src/index.d.ts +++ b/src/index.d.ts @@ -26,7 +26,8 @@ declare module "@firefox-devtools/react-contextmenu" { renderTag?: React.ElementType, triggerOnLeftClick?: boolean, disableIfShiftIsPressed?: boolean, - [key: string]: any + [key: string]: any, + children?: React.ReactNode, } export interface MenuItemProps {