From 1f48325941f07b31f5fb43f2d1320390c5a647e8 Mon Sep 17 00:00:00 2001 From: mt <599155198@qq.com> Date: Tue, 28 Apr 2026 21:20:18 +0800 Subject: [PATCH 1/6] Add comments to GetCommonLabelName in fluid/pkg/ddc/base/validate_test.go. Signed-off-by: mt <599155198@qq.com> --- pkg/ddc/base/validate_test.go | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/pkg/ddc/base/validate_test.go b/pkg/ddc/base/validate_test.go index 9bf3f51a88c..9300b978fa7 100644 --- a/pkg/ddc/base/validate_test.go +++ b/pkg/ddc/base/validate_test.go @@ -84,7 +84,12 @@ func (m *mockRuntimeInfoForValidate) GetPersistentVolumeName() string { return func (m *mockRuntimeInfoForValidate) GetLabelNameForMemory() string { return "" } func (m *mockRuntimeInfoForValidate) GetLabelNameForDisk() string { return "" } func (m *mockRuntimeInfoForValidate) GetLabelNameForTotal() string { return "" } + +// GetCommonLabelName returns the common label name used in runtime validation. +// This is a stub implementation for mockRuntimeInfoForValidate and returns +// an empty string as it is only used for testing purposes. func (m *mockRuntimeInfoForValidate) GetCommonLabelName() string { return "" } + func (m *mockRuntimeInfoForValidate) GetFuseLabelName() string { return "" } func (m *mockRuntimeInfoForValidate) GetRuntimeLabelName() string { return "" } func (m *mockRuntimeInfoForValidate) GetDatasetNumLabelName() string { return "" } From 9a7a848ef27f774c2eae9529056ba21a8d33ef5e Mon Sep 17 00:00:00 2001 From: mt <599155198@qq.com> Date: Tue, 28 Apr 2026 23:13:51 +0800 Subject: [PATCH 2/6] Add comments to GetCommonLabelName in fluid/pkg/ddc/base/validate_test.go. Signed-off-by: mt <599155198@qq.com> --- pkg/ddc/base/validate_test.go | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/pkg/ddc/base/validate_test.go b/pkg/ddc/base/validate_test.go index 9300b978fa7..d7db78cc1ad 100644 --- a/pkg/ddc/base/validate_test.go +++ b/pkg/ddc/base/validate_test.go @@ -84,12 +84,8 @@ func (m *mockRuntimeInfoForValidate) GetPersistentVolumeName() string { return func (m *mockRuntimeInfoForValidate) GetLabelNameForMemory() string { return "" } func (m *mockRuntimeInfoForValidate) GetLabelNameForDisk() string { return "" } func (m *mockRuntimeInfoForValidate) GetLabelNameForTotal() string { return "" } - -// GetCommonLabelName returns the common label name used in runtime validation. -// This is a stub implementation for mockRuntimeInfoForValidate and returns -// an empty string as it is only used for testing purposes. +// GetCommonLabelName returns the common label name. func (m *mockRuntimeInfoForValidate) GetCommonLabelName() string { return "" } - func (m *mockRuntimeInfoForValidate) GetFuseLabelName() string { return "" } func (m *mockRuntimeInfoForValidate) GetRuntimeLabelName() string { return "" } func (m *mockRuntimeInfoForValidate) GetDatasetNumLabelName() string { return "" } From 74926efa2c9e95228e8bb3f10563fcfc4f73c7c9 Mon Sep 17 00:00:00 2001 From: mt <599155198@qq.com> Date: Tue, 28 Apr 2026 23:22:50 +0800 Subject: [PATCH 3/6] Add comments to GetCommonLabelName in fluid/pkg/ddc/base/validate_test.go. Signed-off-by: mt <599155198@qq.com> --- pkg/ddc/base/validate_test.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/pkg/ddc/base/validate_test.go b/pkg/ddc/base/validate_test.go index d7db78cc1ad..2d664ec7257 100644 --- a/pkg/ddc/base/validate_test.go +++ b/pkg/ddc/base/validate_test.go @@ -80,10 +80,10 @@ func (m *mockRuntimeInfoForValidate) GetOwnerDatasetUID() string { return m.owne func (m *mockRuntimeInfoForValidate) IsPlacementModeSet() bool { return m.placementModeSet } // Conventions interface methods (stub implementations) -func (m *mockRuntimeInfoForValidate) GetPersistentVolumeName() string { return "" } -func (m *mockRuntimeInfoForValidate) GetLabelNameForMemory() string { return "" } -func (m *mockRuntimeInfoForValidate) GetLabelNameForDisk() string { return "" } -func (m *mockRuntimeInfoForValidate) GetLabelNameForTotal() string { return "" } +func (m *mockRuntimeInfoForValidate) GetPersistentVolumeName() string { return "" } +func (m *mockRuntimeInfoForValidate) GetLabelNameForMemory() string { return "" } +func (m *mockRuntimeInfoForValidate) GetLabelNameForDisk() string { return "" } +func (m *mockRuntimeInfoForValidate) GetLabelNameForTotal() string { return "" } // GetCommonLabelName returns the common label name. func (m *mockRuntimeInfoForValidate) GetCommonLabelName() string { return "" } func (m *mockRuntimeInfoForValidate) GetFuseLabelName() string { return "" } From 2cebf88f9eb073d33dfac942fa74d5f6bc193ba4 Mon Sep 17 00:00:00 2001 From: mt <599155198@qq.com> Date: Tue, 28 Apr 2026 23:36:45 +0800 Subject: [PATCH 4/6] Add comments to GetCommonLabelName in fluid/pkg/ddc/base/validate_test.go. Signed-off-by: mt <599155198@qq.com> --- pkg/ddc/base/validate_test.go | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/pkg/ddc/base/validate_test.go b/pkg/ddc/base/validate_test.go index 2d664ec7257..9bf3f51a88c 100644 --- a/pkg/ddc/base/validate_test.go +++ b/pkg/ddc/base/validate_test.go @@ -80,11 +80,10 @@ func (m *mockRuntimeInfoForValidate) GetOwnerDatasetUID() string { return m.owne func (m *mockRuntimeInfoForValidate) IsPlacementModeSet() bool { return m.placementModeSet } // Conventions interface methods (stub implementations) -func (m *mockRuntimeInfoForValidate) GetPersistentVolumeName() string { return "" } -func (m *mockRuntimeInfoForValidate) GetLabelNameForMemory() string { return "" } -func (m *mockRuntimeInfoForValidate) GetLabelNameForDisk() string { return "" } -func (m *mockRuntimeInfoForValidate) GetLabelNameForTotal() string { return "" } -// GetCommonLabelName returns the common label name. +func (m *mockRuntimeInfoForValidate) GetPersistentVolumeName() string { return "" } +func (m *mockRuntimeInfoForValidate) GetLabelNameForMemory() string { return "" } +func (m *mockRuntimeInfoForValidate) GetLabelNameForDisk() string { return "" } +func (m *mockRuntimeInfoForValidate) GetLabelNameForTotal() string { return "" } func (m *mockRuntimeInfoForValidate) GetCommonLabelName() string { return "" } func (m *mockRuntimeInfoForValidate) GetFuseLabelName() string { return "" } func (m *mockRuntimeInfoForValidate) GetRuntimeLabelName() string { return "" } From dc96537732b06abb5c153fe7e8011d161544d84b Mon Sep 17 00:00:00 2001 From: mt <599155198@qq.com> Date: Wed, 29 Apr 2026 10:52:49 +0800 Subject: [PATCH 5/6] Add comments to GetCommonLabelName in fluid/pkg/ddc/base/validate_test.go. Signed-off-by: mt <599155198@qq.com> --- pkg/ddc/base/validate_test.go | 1 + 1 file changed, 1 insertion(+) diff --git a/pkg/ddc/base/validate_test.go b/pkg/ddc/base/validate_test.go index 9bf3f51a88c..d7db78cc1ad 100644 --- a/pkg/ddc/base/validate_test.go +++ b/pkg/ddc/base/validate_test.go @@ -84,6 +84,7 @@ func (m *mockRuntimeInfoForValidate) GetPersistentVolumeName() string { return func (m *mockRuntimeInfoForValidate) GetLabelNameForMemory() string { return "" } func (m *mockRuntimeInfoForValidate) GetLabelNameForDisk() string { return "" } func (m *mockRuntimeInfoForValidate) GetLabelNameForTotal() string { return "" } +// GetCommonLabelName returns the common label name. func (m *mockRuntimeInfoForValidate) GetCommonLabelName() string { return "" } func (m *mockRuntimeInfoForValidate) GetFuseLabelName() string { return "" } func (m *mockRuntimeInfoForValidate) GetRuntimeLabelName() string { return "" } From 2597bd10b737a9885e0871d6347e85e649f3c9e3 Mon Sep 17 00:00:00 2001 From: mt <599155198@qq.com> Date: Wed, 29 Apr 2026 11:11:32 +0800 Subject: [PATCH 6/6] Add comments to GetCommonLabelName in fluid/pkg/ddc/base/validate_test.go. Signed-off-by: mt <599155198@qq.com> --- pkg/ddc/base/validate_test.go | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/pkg/ddc/base/validate_test.go b/pkg/ddc/base/validate_test.go index d7db78cc1ad..3d8ec2e5273 100644 --- a/pkg/ddc/base/validate_test.go +++ b/pkg/ddc/base/validate_test.go @@ -80,10 +80,11 @@ func (m *mockRuntimeInfoForValidate) GetOwnerDatasetUID() string { return m.owne func (m *mockRuntimeInfoForValidate) IsPlacementModeSet() bool { return m.placementModeSet } // Conventions interface methods (stub implementations) -func (m *mockRuntimeInfoForValidate) GetPersistentVolumeName() string { return "" } -func (m *mockRuntimeInfoForValidate) GetLabelNameForMemory() string { return "" } -func (m *mockRuntimeInfoForValidate) GetLabelNameForDisk() string { return "" } -func (m *mockRuntimeInfoForValidate) GetLabelNameForTotal() string { return "" } +func (m *mockRuntimeInfoForValidate) GetPersistentVolumeName() string { return "" } +func (m *mockRuntimeInfoForValidate) GetLabelNameForMemory() string { return "" } +func (m *mockRuntimeInfoForValidate) GetLabelNameForDisk() string { return "" } +func (m *mockRuntimeInfoForValidate) GetLabelNameForTotal() string { return "" } + // GetCommonLabelName returns the common label name. func (m *mockRuntimeInfoForValidate) GetCommonLabelName() string { return "" } func (m *mockRuntimeInfoForValidate) GetFuseLabelName() string { return "" }