From 22ef84513389700047e3ffcbaf1f6467174373d3 Mon Sep 17 00:00:00 2001 From: camsim99 Date: Mon, 14 Feb 2022 11:03:24 -0800 Subject: [PATCH 1/2] Add deprecation warnings for Android engine --- build/android/gyp/javac.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/build/android/gyp/javac.py b/build/android/gyp/javac.py index e748026dc6..c9b37f21c7 100755 --- a/build/android/gyp/javac.py +++ b/build/android/gyp/javac.py @@ -78,7 +78,11 @@ def DoJavac( # javac pulling a default encoding from the user's environment. '-encoding', 'UTF-8', '-classpath', ':'.join(classpath), - '-d', classes_dir] + '-d', classes_dir, + # TODO(camsim99): Make deprecation warnings fatal and remove limit + # when all 123 (at the time of this comment) deprecations are fixed. + '-Xlint:deprecation', + '-Xmaxwarns', '123'] if bootclasspath: javac_args.extend([ @@ -88,7 +92,6 @@ def DoJavac( ]) if chromium_code: - # TODO(aurimas): re-enable '-Xlint:deprecation' checks once they are fixed. javac_args.extend(['-Xlint:unchecked']) else: # XDignore.symbol.file makes javac compile against rt.jar instead of From dde7861013c73f3740f49db591ca432c01ef29fc Mon Sep 17 00:00:00 2001 From: camsim99 Date: Thu, 17 Feb 2022 15:11:05 -0800 Subject: [PATCH 2/2] Add issue reference --- build/android/gyp/javac.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/build/android/gyp/javac.py b/build/android/gyp/javac.py index c9b37f21c7..00936b7d8a 100755 --- a/build/android/gyp/javac.py +++ b/build/android/gyp/javac.py @@ -80,7 +80,8 @@ def DoJavac( '-classpath', ':'.join(classpath), '-d', classes_dir, # TODO(camsim99): Make deprecation warnings fatal and remove limit - # when all 123 (at the time of this comment) deprecations are fixed. + # when all 123 (at the time of this comment) deprecations are fixed: + # https://github.com/flutter/flutter/issues/98602. '-Xlint:deprecation', '-Xmaxwarns', '123']