From 56e6c5aa40531efe9f3ae080745ef2609b16d5b6 Mon Sep 17 00:00:00 2001 From: Elliott Brooks <21270878+elliette@users.noreply.github.com> Date: Mon, 18 Mar 2024 10:57:03 -0700 Subject: [PATCH] Added TODOs --- tool/build_release.sh | 4 +++- tool/lib/commands/build.dart | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/tool/build_release.sh b/tool/build_release.sh index 038dc5243fb..57450bebeeb 100755 --- a/tool/build_release.sh +++ b/tool/build_release.sh @@ -62,7 +62,9 @@ flutter pub get flutter build web \ --web-renderer canvaskit \ --pwa-strategy=offline-first \ - --dart2js-optimization=O1 \ + # TODO(elliette): Compile with O1 optimization once + # https://github.com/dart-lang/sdk/issues/55234 is fixed: + # --dart2js-optimization=O1 \ --release \ --no-tree-shake-icons diff --git a/tool/lib/commands/build.dart b/tool/lib/commands/build.dart index 74db2b25a48..1638e70da9e 100644 --- a/tool/lib/commands/build.dart +++ b/tool/lib/commands/build.dart @@ -95,8 +95,10 @@ class BuildCommand extends Command { '--web-renderer', 'canvaskit', '--pwa-strategy=offline-first', + // TODO(elliette): Compile with O1 optimization once + // https://github.com/dart-lang/sdk/issues/55234 is fixed: // Enable default optimizations: https://dart.dev/tools/dart-compile#js - '--dart2js-optimization=O1', + // '--dart2js-optimization=O1', if (buildMode != 'debug') '--$buildMode', '--no-tree-shake-icons', ],