From 56872cee03803f3036249778193ce37b70fa6943 Mon Sep 17 00:00:00 2001 From: hangyujin <108393416+hangyujin@users.noreply.github.com> Date: Mon, 18 Mar 2024 17:26:48 -0700 Subject: [PATCH 1/3] Update _deep_links_api.dart --- .../devtools_app/lib/src/shared/server/_deep_links_api.dart | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/devtools_app/lib/src/shared/server/_deep_links_api.dart b/packages/devtools_app/lib/src/shared/server/_deep_links_api.dart index 9a333e1a715..45304005d3b 100644 --- a/packages/devtools_app/lib/src/shared/server/_deep_links_api.dart +++ b/packages/devtools_app/lib/src/shared/server/_deep_links_api.dart @@ -14,7 +14,8 @@ Future> requestAndroidBuildVariants(String path) async { ); final resp = await request(uri.toString()); if (resp?.statusOk ?? false) { - return json.decode(resp!.body); + final jsonObject = jsonDecode(resp!.body) as List; + return jsonObject.map((dynamic item) => item as String).toList(); } else { logWarning(resp, DeeplinkApi.androidBuildVariants); } From c788b5e653eeab25053d144edd9510b487c73e70 Mon Sep 17 00:00:00 2001 From: hangyujin <108393416+hangyujin@users.noreply.github.com> Date: Mon, 18 Mar 2024 17:36:56 -0700 Subject: [PATCH 2/3] Update _deep_links_api.dart --- .../devtools_app/lib/src/shared/server/_deep_links_api.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/devtools_app/lib/src/shared/server/_deep_links_api.dart b/packages/devtools_app/lib/src/shared/server/_deep_links_api.dart index 45304005d3b..4dbb9e89c3d 100644 --- a/packages/devtools_app/lib/src/shared/server/_deep_links_api.dart +++ b/packages/devtools_app/lib/src/shared/server/_deep_links_api.dart @@ -15,7 +15,7 @@ Future> requestAndroidBuildVariants(String path) async { final resp = await request(uri.toString()); if (resp?.statusOk ?? false) { final jsonObject = jsonDecode(resp!.body) as List; - return jsonObject.map((dynamic item) => item as String).toList(); + return jsonObject.map((item) => item as String).toList(); } else { logWarning(resp, DeeplinkApi.androidBuildVariants); } From de35f60ee9526bf995a94948e1202a367544ee6b Mon Sep 17 00:00:00 2001 From: hangyujin <108393416+hangyujin@users.noreply.github.com> Date: Tue, 19 Mar 2024 15:13:56 -0700 Subject: [PATCH 3/3] resolve comments --- .../devtools_app/lib/src/shared/server/_deep_links_api.dart | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/packages/devtools_app/lib/src/shared/server/_deep_links_api.dart b/packages/devtools_app/lib/src/shared/server/_deep_links_api.dart index 4dbb9e89c3d..b176c75d865 100644 --- a/packages/devtools_app/lib/src/shared/server/_deep_links_api.dart +++ b/packages/devtools_app/lib/src/shared/server/_deep_links_api.dart @@ -14,8 +14,7 @@ Future> requestAndroidBuildVariants(String path) async { ); final resp = await request(uri.toString()); if (resp?.statusOk ?? false) { - final jsonObject = jsonDecode(resp!.body) as List; - return jsonObject.map((item) => item as String).toList(); + return (jsonDecode(resp!.body) as List).cast(); } else { logWarning(resp, DeeplinkApi.androidBuildVariants); }