From ecb3cb2db7a5a3c7c7913b4b8ef47cc783f98dfd Mon Sep 17 00:00:00 2001 From: Elliott Brooks <21270878+elliette@users.noreply.github.com> Date: Tue, 14 Oct 2025 13:00:50 -0700 Subject: [PATCH 1/3] Update to latest Flutter candidate version --- flutter-candidate.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/flutter-candidate.txt b/flutter-candidate.txt index 8416e715f5f..ae461d67459 100644 --- a/flutter-candidate.txt +++ b/flutter-candidate.txt @@ -1 +1 @@ -86327198ff0678f46cbdfb3e12f1759d03aa768d +c63c6b08a7114517575bcf3e45275ec7a9f4e87f From 56dc6d765558054b7c9541b26f7762fbd80454d7 Mon Sep 17 00:00:00 2001 From: Elliott Brooks <21270878+elliette@users.noreply.github.com> Date: Wed, 15 Oct 2025 11:09:27 -0700 Subject: [PATCH 2/3] Hardcode value and update comment --- .../devtools_app/benchmark/devtools_benchmarks_test.dart | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/packages/devtools_app/benchmark/devtools_benchmarks_test.dart b/packages/devtools_app/benchmark/devtools_benchmarks_test.dart index 60819df5198..6c9eae96db7 100644 --- a/packages/devtools_app/benchmark/devtools_benchmarks_test.dart +++ b/packages/devtools_app/benchmark/devtools_benchmarks_test.dart @@ -75,7 +75,12 @@ Future _runBenchmarks({bool useWasm = false}) async { for (final devToolsBenchmark in DevToolsBenchmark.values) { final benchmarkName = devToolsBenchmark.id; - final expectedMetrics = expectedBenchmarkMetrics(useWasm: useWasm); + // Note: Due to https://github.com/flutter/flutter/pull/175392 there is no + // longer any difference in benchmark events for skwasm vs. canvaskit. + // + // TODO(https://github.com/flutter/flutter/issues/177057): Remove hardcoded + // useWasm: false param when package:web_benchmarks is updated. + final expectedMetrics = expectedBenchmarkMetrics(useWasm: false); const expectedComputations = BenchmarkMetricComputation.values; final scores = taskResult.scores[benchmarkName] ?? []; expect( From 940c6b6cb180b4d56ecf6b4316e03b3303a7a0e4 Mon Sep 17 00:00:00 2001 From: Elliott Brooks <21270878+elliette@users.noreply.github.com> Date: Wed, 15 Oct 2025 11:25:49 -0700 Subject: [PATCH 3/3] Format --- packages/devtools_app/benchmark/devtools_benchmarks_test.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/devtools_app/benchmark/devtools_benchmarks_test.dart b/packages/devtools_app/benchmark/devtools_benchmarks_test.dart index 6c9eae96db7..d58ad389264 100644 --- a/packages/devtools_app/benchmark/devtools_benchmarks_test.dart +++ b/packages/devtools_app/benchmark/devtools_benchmarks_test.dart @@ -77,7 +77,7 @@ Future _runBenchmarks({bool useWasm = false}) async { final benchmarkName = devToolsBenchmark.id; // Note: Due to https://github.com/flutter/flutter/pull/175392 there is no // longer any difference in benchmark events for skwasm vs. canvaskit. - // + // // TODO(https://github.com/flutter/flutter/issues/177057): Remove hardcoded // useWasm: false param when package:web_benchmarks is updated. final expectedMetrics = expectedBenchmarkMetrics(useWasm: false);