From c6fb5e62619dd39a171bb80b80353a4f9c12192e Mon Sep 17 00:00:00 2001 From: Nathan Rogers Date: Wed, 30 Oct 2019 21:31:53 -0700 Subject: [PATCH] [flutter_runner] Enable Skia tracing by default on Fuchsia Since Flutter tracing is wired up to Fuchsia system level tracing (and that includes Skia tracing within Flutter), it makes more sense to enable Skia tracing by default on Fuchsia, and to control Flutter Skia tracing, rely on whether Fuchsia system tracing is enabled, in progress, and contains the "skia" category. --- shell/platform/fuchsia/flutter/component.cc | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/shell/platform/fuchsia/flutter/component.cc b/shell/platform/fuchsia/flutter/component.cc index 4ba6f06e71735..cc1cfcb5bea56 100644 --- a/shell/platform/fuchsia/flutter/component.cc +++ b/shell/platform/fuchsia/flutter/component.cc @@ -315,9 +315,8 @@ Application::Application( settings_.observatory_host = "127.0.0.1"; #endif - // Set this to true to enable category "skia" trace events. - // TODO(PT-145): Explore enabling this by default. - settings_.trace_skia = false; + // Controls whether category "skia" trace events are enabled. + settings_.trace_skia = true; settings_.icu_data_path = "";