From f6dc2df6c0d265d9f16e153e91f25322f40d1dd8 Mon Sep 17 00:00:00 2001 From: George Wright Date: Wed, 4 Dec 2019 14:33:40 -0800 Subject: [PATCH 1/3] Disable fml_tests until they're fixed on Fuchsia --- BUILD.gn | 1 - 1 file changed, 1 deletion(-) diff --git a/BUILD.gn b/BUILD.gn index 419ae849544a1..9cf17d9643ad0 100644 --- a/BUILD.gn +++ b/BUILD.gn @@ -97,7 +97,6 @@ group("flutter") { if (is_fuchsia) { public_deps += [ "$flutter_root/flow:flow_tests", - "$flutter_root/fml:fml_tests", ] } } From 805b3c729da5aaa50bee9487d1276046f7c9646d Mon Sep 17 00:00:00 2001 From: George Wright Date: Wed, 4 Dec 2019 15:35:43 -0800 Subject: [PATCH 2/3] review update --- BUILD.gn | 2 ++ 1 file changed, 2 insertions(+) diff --git a/BUILD.gn b/BUILD.gn index 9cf17d9643ad0..3aa1f2fa7b998 100644 --- a/BUILD.gn +++ b/BUILD.gn @@ -97,6 +97,8 @@ group("flutter") { if (is_fuchsia) { public_deps += [ "$flutter_root/flow:flow_tests", +# TODO(gw280): Re-enable fml_tests on Fuchsia (https://github.com/flutter/flutter/issues/46122) +# "$flutter_root/fml:fml_tests", ] } } From 26d871c9d2d9ceb9fa07a7a4e051a57912b9aadd Mon Sep 17 00:00:00 2001 From: George Wright Date: Wed, 4 Dec 2019 15:48:59 -0800 Subject: [PATCH 3/3] formatting --- BUILD.gn | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/BUILD.gn b/BUILD.gn index 3aa1f2fa7b998..6711b06124153 100644 --- a/BUILD.gn +++ b/BUILD.gn @@ -97,8 +97,8 @@ group("flutter") { if (is_fuchsia) { public_deps += [ "$flutter_root/flow:flow_tests", -# TODO(gw280): Re-enable fml_tests on Fuchsia (https://github.com/flutter/flutter/issues/46122) -# "$flutter_root/fml:fml_tests", + # TODO(gw280): Re-enable fml_tests on Fuchsia (https://github.com/flutter/flutter/issues/46122) + # "$flutter_root/fml:fml_tests", ] } }