From dc02608b8fda7de8beae1a6d96f06fb265c787bb Mon Sep 17 00:00:00 2001 From: Nurhan Turgut Date: Fri, 21 Feb 2020 10:51:52 -0800 Subject: [PATCH 1/3] add comment to skipped safari test --- lib/web_ui/test/engine/history_test.dart | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/web_ui/test/engine/history_test.dart b/lib/web_ui/test/engine/history_test.dart index 2704335e13592..01e67c388e92d 100644 --- a/lib/web_ui/test/engine/history_test.dart +++ b/lib/web_ui/test/engine/history_test.dart @@ -4,6 +4,7 @@ // @dart = 2.6 @TestOn('vm && linux') +// TODO(nurhan): https://github.com/flutter/flutter/issues/51169 import 'dart:async'; import 'dart:typed_data'; From 48174202bb8255056b9c8f4d50ec92a9db63fac4 Mon Sep 17 00:00:00 2001 From: Nurhan Turgut Date: Fri, 21 Feb 2020 12:27:08 -0800 Subject: [PATCH 2/3] test not running semantics on Mac --- lib/web_ui/test/engine/semantics/semantics_test.dart | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/web_ui/test/engine/semantics/semantics_test.dart b/lib/web_ui/test/engine/semantics/semantics_test.dart index f495acb6006a7..94c5328761d97 100644 --- a/lib/web_ui/test/engine/semantics/semantics_test.dart +++ b/lib/web_ui/test/engine/semantics/semantics_test.dart @@ -3,6 +3,8 @@ // found in the LICENSE file. // @dart = 2.6 +@TestOn('vm && linux') + import 'dart:async'; import 'dart:html' as html; import 'dart:typed_data'; From 4b92b411326ab4b630072e64c6a141ea7c6fb272 Mon Sep 17 00:00:00 2001 From: Nurhan Turgut Date: Fri, 21 Feb 2020 12:46:11 -0800 Subject: [PATCH 3/3] disable semantics test which is unreliable --- lib/web_ui/test/engine/semantics/semantics_test.dart | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/web_ui/test/engine/semantics/semantics_test.dart b/lib/web_ui/test/engine/semantics/semantics_test.dart index 94c5328761d97..9a36447ee5efd 100644 --- a/lib/web_ui/test/engine/semantics/semantics_test.dart +++ b/lib/web_ui/test/engine/semantics/semantics_test.dart @@ -4,6 +4,7 @@ // @dart = 2.6 @TestOn('vm && linux') +// TODO(nurhan): https://github.com/flutter/flutter/issues/50590 import 'dart:async'; import 'dart:html' as html;