From d364c17d9d784a267dad059570965f3fcc26dfee Mon Sep 17 00:00:00 2001 From: Kaushik Iska Date: Wed, 7 Oct 2020 16:35:54 -0700 Subject: [PATCH] [macOS] flutter_desktop_darwin_unittests can be enabled for all runtime modes Given that https://github.com/flutter/flutter/issues/66664 has been fixed --- shell/platform/darwin/macos/framework/Source/FlutterEngine.mm | 1 + testing/run_tests.py | 4 ---- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/shell/platform/darwin/macos/framework/Source/FlutterEngine.mm b/shell/platform/darwin/macos/framework/Source/FlutterEngine.mm index 663ccd21f2fb1..a27860f806fa6 100644 --- a/shell/platform/darwin/macos/framework/Source/FlutterEngine.mm +++ b/shell/platform/darwin/macos/framework/Source/FlutterEngine.mm @@ -267,6 +267,7 @@ - (BOOL)runWithEntrypoint:(NSString*)entrypoint { flutterArguments.command_line_argv = argv.size() > 0 ? argv.data() : nullptr; flutterArguments.platform_message_callback = (FlutterPlatformMessageCallback)OnPlatformMessage; flutterArguments.custom_dart_entrypoint = entrypoint.UTF8String; + flutterArguments.shutdown_dart_vm_when_done = true; static size_t sTaskRunnerIdentifiers = 0; const FlutterTaskRunnerDescription cocoa_task_runner_description = { .struct_size = sizeof(FlutterTaskRunnerDescription), diff --git a/testing/run_tests.py b/testing/run_tests.py index 6b2cf2f18cea3..cfcedd74f7816 100755 --- a/testing/run_tests.py +++ b/testing/run_tests.py @@ -147,10 +147,6 @@ def RunCCTests(build_dir, filter): # These unit-tests are Objective-C and can only run on Darwin. if IsMac(): RunEngineExecutable(build_dir, 'flutter_channels_unittests', filter, shuffle_flags) - - # These tests can only be run on Darwin on debug mode. - # See: https://github.com/flutter/flutter/issues/66664 - if IsMac() and ('debug' in build_dir): RunEngineExecutable(build_dir, 'flutter_desktop_darwin_unittests', filter, shuffle_flags) # https://github.com/flutter/flutter/issues/36296