From ebb33fbb8f80992a97cb165fe4ae3a83233cb366 Mon Sep 17 00:00:00 2001 From: Jim Graham Date: Mon, 22 Mar 2021 00:19:14 -0700 Subject: [PATCH 1/2] Workaround for iOS embedded preroll issue --- flow/layers/platform_view_layer.cc | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/flow/layers/platform_view_layer.cc b/flow/layers/platform_view_layer.cc index 0971f93db777e..7852fb06e5801 100644 --- a/flow/layers/platform_view_layer.cc +++ b/flow/layers/platform_view_layer.cc @@ -26,12 +26,14 @@ void PlatformViewLayer::Preroll(PrerollContext* context, "does not support embedding"; return; } - context->has_platform_view = true; - std::unique_ptr params = - std::make_unique(matrix, size_, - context->mutators_stack); - context->view_embedder->PrerollCompositeEmbeddedView(view_id_, - std::move(params)); + if (paint_bounds().intersects(context->cull_rect)) { + context->has_platform_view = true; + std::unique_ptr params = + std::make_unique(matrix, size_, + context->mutators_stack); + context->view_embedder->PrerollCompositeEmbeddedView(view_id_, + std::move(params)); + } } void PlatformViewLayer::Paint(PaintContext& context) const { From 23d2a94a290203f868752ae53d78e43a5931b31e Mon Sep 17 00:00:00 2001 From: Jim Graham Date: Mon, 22 Mar 2021 01:00:22 -0700 Subject: [PATCH 2/2] fix indentation --- flow/layers/platform_view_layer.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/flow/layers/platform_view_layer.cc b/flow/layers/platform_view_layer.cc index 7852fb06e5801..872ebddbdb5fc 100644 --- a/flow/layers/platform_view_layer.cc +++ b/flow/layers/platform_view_layer.cc @@ -30,9 +30,9 @@ void PlatformViewLayer::Preroll(PrerollContext* context, context->has_platform_view = true; std::unique_ptr params = std::make_unique(matrix, size_, - context->mutators_stack); + context->mutators_stack); context->view_embedder->PrerollCompositeEmbeddedView(view_id_, - std::move(params)); + std::move(params)); } }