From 2a1cfdc4001d241c30c11532d6591926456a8213 Mon Sep 17 00:00:00 2001 From: Sam Rawlins Date: Fri, 23 Apr 2021 13:42:51 -0700 Subject: [PATCH 1/2] Remove "unnecessary" imports. In each library where an import is removed, the library uses some elements provided by the import, BUT there is another import which provides all of the same elements, and at least one more which the library uses. In this change, we remove the imports which can be simply removed in favor of the other already present imports. See https://github.com/dart-lang/sdk/issues/44569 for more information. --- lib/web_ui/lib/src/engine/pointer_binding.dart | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/web_ui/lib/src/engine/pointer_binding.dart b/lib/web_ui/lib/src/engine/pointer_binding.dart index 80a97487434c0..a10ae138298a5 100644 --- a/lib/web_ui/lib/src/engine/pointer_binding.dart +++ b/lib/web_ui/lib/src/engine/pointer_binding.dart @@ -11,8 +11,6 @@ import 'package:meta/meta.dart'; import 'package:ui/src/engine.dart'; import 'package:ui/ui.dart' as ui; -import 'pointer_converter.dart'; - /// Set this flag to true to see all the fired events in the console. const bool _debugLogPointerEvents = false; From 5a3a95317f6c776e278fce51bd734e35732f3905 Mon Sep 17 00:00:00 2001 From: Sam Rawlins Date: Tue, 11 May 2021 12:29:28 -0700 Subject: [PATCH 2/2] A few more --- lib/web_ui/lib/src/engine/html/path_to_svg_clip.dart | 2 -- lib/web_ui/lib/src/engine/html/shaders/normalized_gradient.dart | 1 - lib/web_ui/test/engine/surface/scene_builder_test.dart | 1 - lib/web_ui/test/engine/surface/shaders/shader_builder_test.dart | 1 - 4 files changed, 5 deletions(-) diff --git a/lib/web_ui/lib/src/engine/html/path_to_svg_clip.dart b/lib/web_ui/lib/src/engine/html/path_to_svg_clip.dart index 878ba758957da..27a8a4c5d9de7 100644 --- a/lib/web_ui/lib/src/engine/html/path_to_svg_clip.dart +++ b/lib/web_ui/lib/src/engine/html/path_to_svg_clip.dart @@ -5,8 +5,6 @@ import 'package:ui/src/engine.dart'; import 'package:ui/ui.dart' as ui; -import '../browser_detection.dart'; - /// Counter used for generating clip path id inside an svg tag. int _clipIdCounter = 0; diff --git a/lib/web_ui/lib/src/engine/html/shaders/normalized_gradient.dart b/lib/web_ui/lib/src/engine/html/shaders/normalized_gradient.dart index 5afe9fe0dade9..2b1239783d445 100644 --- a/lib/web_ui/lib/src/engine/html/shaders/normalized_gradient.dart +++ b/lib/web_ui/lib/src/engine/html/shaders/normalized_gradient.dart @@ -7,7 +7,6 @@ import 'dart:typed_data'; import 'package:ui/src/engine.dart'; import 'package:ui/ui.dart' as ui; -import 'shader_builder.dart'; /// Converts colors and stops to typed array of bias, scale and threshold to use /// in shaders. diff --git a/lib/web_ui/test/engine/surface/scene_builder_test.dart b/lib/web_ui/test/engine/surface/scene_builder_test.dart index 04d692c4765ec..c964d4b22d627 100644 --- a/lib/web_ui/test/engine/surface/scene_builder_test.dart +++ b/lib/web_ui/test/engine/surface/scene_builder_test.dart @@ -12,7 +12,6 @@ import 'dart:js_util' as js_util; import 'package:test/bootstrap/browser.dart'; import 'package:test/test.dart'; import 'package:ui/src/engine.dart'; -import 'package:ui/src/engine/html_image_codec.dart'; import 'package:ui/ui.dart' hide window; diff --git a/lib/web_ui/test/engine/surface/shaders/shader_builder_test.dart b/lib/web_ui/test/engine/surface/shaders/shader_builder_test.dart index df67ce9e7962f..336cf4f8d8890 100644 --- a/lib/web_ui/test/engine/surface/shaders/shader_builder_test.dart +++ b/lib/web_ui/test/engine/surface/shaders/shader_builder_test.dart @@ -6,7 +6,6 @@ import 'package:test/bootstrap/browser.dart'; import 'package:test/test.dart'; import 'package:ui/src/engine.dart'; -import 'package:ui/src/engine/html/shaders/shader_builder.dart'; import 'package:ui/ui.dart' hide window; void main() {