From 05f3185f0dc45ba48158c2c713a64f3d29046a59 Mon Sep 17 00:00:00 2001 From: Rich Kadel Date: Mon, 4 Oct 2021 15:20:50 -0700 Subject: [PATCH] Enable testing flutter-embedder-test2 When this test was originally added to the flutter/engine repo, the CI test would not work because the Fuchsia test environment (based on fuchsia's "terminal" product type) did not appear to include the hardware-display-controller-provider package. That package was added to terminal in the fuchsia.git change at fxrev.dev/587281 and once that modified version of the "terminal"-based image is used by fuchsia/engine CI, assuming it was the last blocker, hopefully the test will now pass in CI. The test does pass when run from a development environment. --- testing/fuchsia/test_suites.yaml | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/testing/fuchsia/test_suites.yaml b/testing/fuchsia/test_suites.yaml index 60ab48cb6fa07..23cd4d7ad3fc5 100644 --- a/testing/fuchsia/test_suites.yaml +++ b/testing/fuchsia/test_suites.yaml @@ -4,14 +4,12 @@ # Legacy Component Framework v1 components. - test_command: run-test-component fuchsia-pkg://fuchsia.com/flutter_runner_tests#meta/flutter_runner_tests.cmx package: flutter_runner_tests-0.far -# TODO(richkadel): Enable this test once the CI fuchsia image for femu tests has been updated to -# meet the test requirements. Changes are in progress to support this test. -# - test_command: run-test-component fuchsia-pkg://fuchsia.com/flutter-embedder-test2#meta/flutter-embedder-test2.cmx -# packages: -# - flutter-embedder-test2-0.far -# - gen/flutter/shell/platform/fuchsia/flutter/integration_flutter_tests/embedder/child-view2/child-view2/child-view2.far -# - gen/flutter/shell/platform/fuchsia/flutter/integration_flutter_tests/embedder/parent-view2/parent-view2/parent-view2.far -# - flutter_jit_runner-0.far +- test_command: run-test-component fuchsia-pkg://fuchsia.com/flutter-embedder-test2#meta/flutter-embedder-test2.cmx + packages: + - flutter-embedder-test2-0.far + - gen/flutter/shell/platform/fuchsia/flutter/integration_flutter_tests/embedder/child-view2/child-view2/child-view2.far + - gen/flutter/shell/platform/fuchsia/flutter/integration_flutter_tests/embedder/parent-view2/parent-view2/parent-view2.far + - flutter_jit_runner-0.far # v2 components. - test_command: run-test-suite fuchsia-pkg://fuchsia.com/flutter_runner_tzdata_tests#meta/flutter_runner_tzdata_tests.cm