From 52a5fe0fc0064389ce25105b2e96f13b7394bb67 Mon Sep 17 00:00:00 2001 From: Jenn Magder Date: Mon, 15 Nov 2021 11:32:24 -0800 Subject: [PATCH 1/2] Turn on clang-analyzer-osx errors --- .clang-tidy | 1 + 1 file changed, 1 insertion(+) diff --git a/.clang-tidy b/.clang-tidy index fe6d3fcfd359f..18c5b7f1ec360 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -1 +1,2 @@ Checks: 'google-*' +WarningsAsErrors: 'clang-analyzer-osx.*' From d3a1d5d1897585f2d1033c6699e577e105c251e5 Mon Sep 17 00:00:00 2001 From: Jenn Magder Date: Mon, 15 Nov 2021 15:01:31 -0800 Subject: [PATCH 2/2] Add comment --- .clang-tidy | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.clang-tidy b/.clang-tidy index 18c5b7f1ec360..0089977b0f702 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -1,2 +1,8 @@ Checks: 'google-*' + +# Only warnings treated as errors are reported +# in the "ci/lint.sh" script and pre-push git hook. +# Add checks when all warnings are fixed +# to prevent new warnings from being introduced. +# https://github.com/flutter/flutter/issues/93279 WarningsAsErrors: 'clang-analyzer-osx.*'