From 9e3ca86e2c2660f112020cbd35f576ba8a70f227 Mon Sep 17 00:00:00 2001 From: ColdPaleLight Date: Wed, 16 Mar 2022 16:42:08 +0800 Subject: [PATCH 1/2] Disable several tests due to flakiness --- shell/common/shell_unittests.cc | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/shell/common/shell_unittests.cc b/shell/common/shell_unittests.cc index 2265661edabf2..72bcfe9c173fc 100644 --- a/shell/common/shell_unittests.cc +++ b/shell/common/shell_unittests.cc @@ -1277,12 +1277,14 @@ TEST_F(ShellTest, DestroyShell(std::move(shell)); } +// TODO(https://github.com/flutter/flutter/issues/95751): Disabled due to +// flakiness. // TODO(https://github.com/flutter/flutter/issues/59816): Enable on fuchsia. TEST_F(ShellTest, #if defined(OS_FUCHSIA) DISABLED_ResubmitFrame #else - ResubmitFrame + DISABLED_ResubmitFrame #endif ) { auto settings = CreateSettingsForFixture(); @@ -2392,7 +2394,9 @@ TEST_F(ShellTest, OnServiceProtocolEstimateRasterCacheMemoryWorks) { DestroyShell(std::move(shell)); } -TEST_F(ShellTest, DiscardLayerTreeOnResize) { +// TODO(https://github.com/flutter/flutter/issues/95751): Disabled due to +// flakiness. +TEST_F(ShellTest, DISABLED_DiscardLayerTreeOnResize) { auto settings = CreateSettingsForFixture(); SkISize wrong_size = SkISize::Make(400, 100); @@ -2442,7 +2446,9 @@ TEST_F(ShellTest, DiscardLayerTreeOnResize) { DestroyShell(std::move(shell)); } -TEST_F(ShellTest, DiscardResubmittedLayerTreeOnResize) { +// TODO(https://github.com/flutter/flutter/issues/95751): Disabled due to +// flakiness. +TEST_F(ShellTest, DISABLED_DiscardResubmittedLayerTreeOnResize) { auto settings = CreateSettingsForFixture(); SkISize origin_size = SkISize::Make(400, 100); From bb69362b989bdfcf59255fe7b557aa26f284f48a Mon Sep 17 00:00:00 2001 From: ColdPaleLight Date: Thu, 17 Mar 2022 10:56:22 +0800 Subject: [PATCH 2/2] update linked issue --- shell/common/shell_unittests.cc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/shell/common/shell_unittests.cc b/shell/common/shell_unittests.cc index 72bcfe9c173fc..bee55ab690190 100644 --- a/shell/common/shell_unittests.cc +++ b/shell/common/shell_unittests.cc @@ -1277,7 +1277,7 @@ TEST_F(ShellTest, DestroyShell(std::move(shell)); } -// TODO(https://github.com/flutter/flutter/issues/95751): Disabled due to +// TODO(https://github.com/flutter/flutter/issues/100273): Disabled due to // flakiness. // TODO(https://github.com/flutter/flutter/issues/59816): Enable on fuchsia. TEST_F(ShellTest, @@ -2394,7 +2394,7 @@ TEST_F(ShellTest, OnServiceProtocolEstimateRasterCacheMemoryWorks) { DestroyShell(std::move(shell)); } -// TODO(https://github.com/flutter/flutter/issues/95751): Disabled due to +// TODO(https://github.com/flutter/flutter/issues/100273): Disabled due to // flakiness. TEST_F(ShellTest, DISABLED_DiscardLayerTreeOnResize) { auto settings = CreateSettingsForFixture(); @@ -2446,7 +2446,7 @@ TEST_F(ShellTest, DISABLED_DiscardLayerTreeOnResize) { DestroyShell(std::move(shell)); } -// TODO(https://github.com/flutter/flutter/issues/95751): Disabled due to +// TODO(https://github.com/flutter/flutter/issues/100273): Disabled due to // flakiness. TEST_F(ShellTest, DISABLED_DiscardResubmittedLayerTreeOnResize) { auto settings = CreateSettingsForFixture();