From 6878a7b24a070ea3fc84cc8296f21d17a3ec7430 Mon Sep 17 00:00:00 2001 From: Mouad Debbar Date: Thu, 17 Mar 2022 14:48:03 -0400 Subject: [PATCH] Revert "[web] Remove the --passfail flag when calling goldctl in post-submit (#32071)" This reverts commit 852e800f424666ac2f24775dc01ba2d07cc2b9f3. --- web_sdk/web_test_utils/lib/skia_client.dart | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/web_sdk/web_test_utils/lib/skia_client.dart b/web_sdk/web_test_utils/lib/skia_client.dart index 4d3d5f2a5324d..025f509ddd106 100644 --- a/web_sdk/web_test_utils/lib/skia_client.dart +++ b/web_sdk/web_test_utils/lib/skia_client.dart @@ -137,6 +137,7 @@ class SkiaGoldClient { '--commit', commitHash, '--keys-file', keys.path, '--failure-file', failures.path, + '--passfail', ]; if (imgtestInitCommand.contains(null)) { @@ -227,9 +228,6 @@ class SkiaGoldClient { '--commit', commitHash, '--keys-file', keys.path, '--failure-file', failures.path, - // This is running in pre-submit so it's okay for the `goldctl` commands - // to fail when the images don't match. But during post-submit - // (in `_imgtestInit`) we shouldn't let the command fail. '--passfail', '--crs', 'github', '--patchset_id', commitHash,