From 50750607a3ac945a1b1eba7e5b0484af9dc6be1b Mon Sep 17 00:00:00 2001 From: Michael Ludwig Date: Tue, 23 Aug 2022 20:37:29 -0400 Subject: [PATCH 1/2] Set temporary GN arg for Skia roll Flutter must atomically update some unit tests alongside enabling the new saveLayer codepath in Skia. Currently the legacy path is enabled through Skia's flutter_defines.gni, and this will allow control to move into the flutter repo. --- tools/gn | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/gn b/tools/gn index 2b8e94f3363fe..363c8a6c693c4 100755 --- a/tools/gn +++ b/tools/gn @@ -232,6 +232,8 @@ def to_gn_args(args): gn_args['skia_use_wuffs'] = True gn_args['skia_use_expat'] = args.target_os == 'android' gn_args['skia_use_fontconfig'] = args.enable_fontconfig + gn_args['skia_use_legacy_layer_bounds' + ] = True # Temporary: see skbug.com/12083, skbug.com/12303 if args.enable_skshaper: gn_args['skia_use_icu'] = True From ddb0a4f280482d2fd5da82907caece12c3088b63 Mon Sep 17 00:00:00 2001 From: Michael Ludwig Date: Tue, 23 Aug 2022 20:54:04 -0400 Subject: [PATCH 2/2] fix formatting --- tools/gn | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/gn b/tools/gn index 363c8a6c693c4..7b218ff116802 100755 --- a/tools/gn +++ b/tools/gn @@ -233,7 +233,7 @@ def to_gn_args(args): gn_args['skia_use_expat'] = args.target_os == 'android' gn_args['skia_use_fontconfig'] = args.enable_fontconfig gn_args['skia_use_legacy_layer_bounds' - ] = True # Temporary: see skbug.com/12083, skbug.com/12303 + ] = True # Temporary: See skbug.com/12083, skbug.com/12303. if args.enable_skshaper: gn_args['skia_use_icu'] = True