From bbc8bcb722d5d5a516cd63a1188c8ed7b0d51e23 Mon Sep 17 00:00:00 2001 From: Aaron Clarke Date: Wed, 9 Nov 2022 13:00:39 -0800 Subject: [PATCH 1/6] Turned on performance-move-const-arg everywhere. e ignored, and an empty message aborts the commit. --- .clang-tidy | 1 + ci/lint.sh | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/.clang-tidy b/.clang-tidy index 6bd27668fd974..7947394ce3950 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -29,6 +29,7 @@ readability-identifier-naming,\ clang-diagnostic-*,\ google-objc-*,\ google-explicit-constructor,\ +performance-move-const-arg,\ performance-unnecessary-value-param" CheckOptions: diff --git a/ci/lint.sh b/ci/lint.sh index 7c6c4e0c314b8..2e416284ce611 100755 --- a/ci/lint.sh +++ b/ci/lint.sh @@ -34,8 +34,8 @@ DART_BIN="${SRC_DIR}/third_party/dart/tools/sdks/dart-sdk/bin" DART="${DART_BIN}/dart" # TODO(https://github.com/flutter/flutter/issues/113848): Migrate all platforms # to have this as an error. -MAC_HOST_WARNINGS_AS_ERRORS="performance-move-const-arg" +FLUTTER_LINT_PRINT_FIX=1 # FLUTTER_LINT_PRINT_FIX will make it so that fix is executed and the generated # diff is printed to stdout if clang-tidy fails. This is helpful for enabling # new lints. From ab5ce7112c18631d20c9da5162531438ef60f737 Mon Sep 17 00:00:00 2001 From: Aaron Clarke Date: Wed, 9 Nov 2022 13:27:25 -0800 Subject: [PATCH 2/6] android fix --- impeller/renderer/backend/vulkan/pipeline_library_vk.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/impeller/renderer/backend/vulkan/pipeline_library_vk.cc b/impeller/renderer/backend/vulkan/pipeline_library_vk.cc index b282b4fdd9d38..7c6a9e85634f1 100644 --- a/impeller/renderer/backend/vulkan/pipeline_library_vk.cc +++ b/impeller/renderer/backend/vulkan/pipeline_library_vk.cc @@ -262,7 +262,7 @@ std::unique_ptr PipelineLibraryVK::CreatePipeline( info.setPName("main"); info.setModule( ShaderFunctionVK::Cast(entrypoint.second.get())->GetModule()); - shader_stages.push_back(std::move(info)); + shader_stages.push_back(info); } pipeline_info.setStages(shader_stages); From c0ffdf584b2c9d6fc0889e8fe6dc75e21b3f2178 Mon Sep 17 00:00:00 2001 From: Aaron Clarke Date: Wed, 9 Nov 2022 13:38:44 -0800 Subject: [PATCH 3/6] ios patch --- .../darwin/ios/framework/Source/FlutterPlatformViews.mm | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/shell/platform/darwin/ios/framework/Source/FlutterPlatformViews.mm b/shell/platform/darwin/ios/framework/Source/FlutterPlatformViews.mm index 90885780576b0..51085c935577f 100644 --- a/shell/platform/darwin/ios/framework/Source/FlutterPlatformViews.mm +++ b/shell/platform/darwin/ios/framework/Source/FlutterPlatformViews.mm @@ -734,8 +734,7 @@ - (BOOL)flt_hasFirstResponderInViewHierarchySubtree { int64_t view_id, int64_t overlay_id) { FML_DCHECK(flutter_view_); - std::shared_ptr layer = - layer_pool_->GetLayer(gr_context, std::move(ios_context)); + std::shared_ptr layer = layer_pool_->GetLayer(gr_context, ios_context); UIView* overlay_view_wrapper = layer->overlay_view_wrapper.get(); auto screenScale = [UIScreen mainScreen].scale; From 20b5c6b5582839a964575dcce32610ab431f959e Mon Sep 17 00:00:00 2001 From: Aaron Clarke Date: Wed, 9 Nov 2022 14:01:05 -0800 Subject: [PATCH 4/6] turned off lint fix printer --- ci/lint.sh | 1 - 1 file changed, 1 deletion(-) diff --git a/ci/lint.sh b/ci/lint.sh index 2e416284ce611..4aa22771749bb 100755 --- a/ci/lint.sh +++ b/ci/lint.sh @@ -35,7 +35,6 @@ DART="${DART_BIN}/dart" # TODO(https://github.com/flutter/flutter/issues/113848): Migrate all platforms # to have this as an error. -FLUTTER_LINT_PRINT_FIX=1 # FLUTTER_LINT_PRINT_FIX will make it so that fix is executed and the generated # diff is printed to stdout if clang-tidy fails. This is helpful for enabling # new lints. From 4d30c2be91ceb6352ce8c0ff2bd594f5daa7931c Mon Sep 17 00:00:00 2001 From: Aaron Clarke Date: Wed, 9 Nov 2022 14:38:53 -0800 Subject: [PATCH 5/6] removed flag --- ci/lint.sh | 1 - 1 file changed, 1 deletion(-) diff --git a/ci/lint.sh b/ci/lint.sh index 4aa22771749bb..cabb111057fe6 100755 --- a/ci/lint.sh +++ b/ci/lint.sh @@ -56,7 +56,6 @@ cd "$SCRIPT_DIR" --disable-dart-dev \ "$SRC_DIR/flutter/tools/clang_tidy/bin/main.dart" \ --src-dir="$SRC_DIR" \ - --mac-host-warnings-as-errors="$MAC_HOST_WARNINGS_AS_ERRORS" \ $fix_flag \ "$@" && true # errors ignored clang_tidy_return=$? From ce82e221c3f505284ffaa01247a260444b1666bf Mon Sep 17 00:00:00 2001 From: Aaron Clarke Date: Wed, 9 Nov 2022 14:39:19 -0800 Subject: [PATCH 6/6] removed comment --- ci/lint.sh | 2 -- 1 file changed, 2 deletions(-) diff --git a/ci/lint.sh b/ci/lint.sh index cabb111057fe6..ed7ced728409b 100755 --- a/ci/lint.sh +++ b/ci/lint.sh @@ -32,8 +32,6 @@ SRC_DIR="$(cd "$SCRIPT_DIR/../.."; pwd -P)" FLUTTER_DIR="$(cd "$SCRIPT_DIR/.."; pwd -P)" DART_BIN="${SRC_DIR}/third_party/dart/tools/sdks/dart-sdk/bin" DART="${DART_BIN}/dart" -# TODO(https://github.com/flutter/flutter/issues/113848): Migrate all platforms -# to have this as an error. # FLUTTER_LINT_PRINT_FIX will make it so that fix is executed and the generated # diff is printed to stdout if clang-tidy fails. This is helpful for enabling