From 258e18eb116d7775b1b85a62ddaca2e8eaf6340e Mon Sep 17 00:00:00 2001 From: joshualitt Date: Mon, 27 Mar 2023 15:22:31 -0700 Subject: [PATCH] Revert "[web] Add `js_types` sources to build. (#40597)" This reverts commit 50f83749740a7f78ccf539834b2045c83025cf24. --- sky/packages/sky_engine/BUILD.gn | 21 --------------------- sky/packages/sky_engine/lib/_embedder.yaml | 4 ---- 2 files changed, 25 deletions(-) diff --git a/sky/packages/sky_engine/BUILD.gn b/sky/packages/sky_engine/BUILD.gn index ae0207d6a5cea..dad2a027d2f4d 100644 --- a/sky/packages/sky_engine/BUILD.gn +++ b/sky/packages/sky_engine/BUILD.gn @@ -8,7 +8,6 @@ import("//flutter/lib/ui/dart_ui.gni") import("//third_party/dart/sdk/lib/_http/http_sources.gni") import( "//third_party/dart/sdk/lib/_internal/js_runtime/interceptors_sources.gni") -import("//third_party/dart/sdk/lib/_internal/js_shared/js_types_sources.gni") import("//third_party/dart/sdk/lib/async/async_sources.gni") import("//third_party/dart/sdk/lib/collection/collection_sources.gni") import("//third_party/dart/sdk/lib/convert/convert_sources.gni") @@ -19,7 +18,6 @@ import("//third_party/dart/sdk/lib/html/html_sources.gni") import("//third_party/dart/sdk/lib/internal/internal_sources.gni") import("//third_party/dart/sdk/lib/io/io_sources.gni") import("//third_party/dart/sdk/lib/isolate/isolate_sources.gni") -import("//third_party/dart/sdk/lib/js/js_annotations_sources.gni") import("//third_party/dart/sdk/lib/js/js_sources.gni") import("//third_party/dart/sdk/lib/js_interop/js_interop_sources.gni") import("//third_party/dart/sdk/lib/js_util/js_util_sources.gni") @@ -88,19 +86,6 @@ copy("_interceptors") { ] } -copy("_js_annotations") { - lib_path = rebase_path("js", "", dart_sdk_lib_path) - sources = rebase_path(js_annotations_sdk_sources, "", lib_path) - outputs = [ "$root_gen_dir/dart-pkg/sky_engine/lib/_js_annotations/{{source_file_part}}" ] -} - -copy("_js_types") { - lib_path = rebase_path("_internal/js_shared", "", dart_sdk_lib_path) - sources = rebase_path(js_types_sdk_sources, "", lib_path) - outputs = - [ "$root_gen_dir/dart-pkg/sky_engine/lib/_js_types/{{source_file_part}}" ] -} - copy("internal") { lib_path = rebase_path("internal", "", dart_sdk_lib_path) sources = rebase_path(internal_sdk_sources, "", lib_path) @@ -195,8 +180,6 @@ group("copy_dart_sdk") { deps = [ ":_http", ":_interceptors", - ":_js_annotations", - ":_js_types", ":async", ":collection", ":convert", @@ -247,10 +230,6 @@ generated_file("_embedder_yaml") { " # public API, e.g. List being Iterable by virtue of implementing", " # EfficientLengthIterable. Not including this library yields analysis errors.", " \"dart:_internal\": \"internal/internal.dart\"", - " # The _js_annotations library is also needed for the same reasons as _internal.", - " \"dart:_js_annotations\": \"_js_annotations/_js_annotations.dart\"", - " # The _js_types library is also needed for the same reasons as _internal.", - " \"dart:_js_types\": \"_js_types/js_types.dart\"", " \"dart:nativewrappers\": \"_empty.dart\"", ] } diff --git a/sky/packages/sky_engine/lib/_embedder.yaml b/sky/packages/sky_engine/lib/_embedder.yaml index 69436dc7d948b..bcd988cde7318 100644 --- a/sky/packages/sky_engine/lib/_embedder.yaml +++ b/sky/packages/sky_engine/lib/_embedder.yaml @@ -25,8 +25,4 @@ embedded_libs: # public API, e.g. List being Iterable by virtue of implementing # EfficientLengthIterable. Not including this library yields analysis errors. "dart:_internal": "../../../../../third_party/dart/sdk/lib/internal/internal.dart" - # The _js_annotations library is also needed for the same reasons as _internal. - "dart:_js_annotations": "../../../../../third_party/dart/sdk/lib/js/_js_annotations.dart" - # The _js_types library is also needed for the same reasons as _internal. - "dart:_js_types": "../../../../../third_party/dart/sdk/lib/_internal/js_shared/lib/js_types.dart" "dart:nativewrappers": "_empty.dart"