From ca8254f582183ecb10b7d217adf281a352c3209e Mon Sep 17 00:00:00 2001 From: Godofredo Contreras Date: Mon, 1 May 2023 08:18:08 -0700 Subject: [PATCH 1/2] Add the verify exported symbols to linux builds. Engine V2 builds were missing a step to verify the exported symbols. This PR is adding the step in preparation to migrate the android builds to engine v2. --- ci/builders/linux_android_aot_engine.json | 14 +++++++++++++- ci/builders/linux_android_debug_engine.json | 14 +++++++++++++- ci/builders/linux_host_engine.json | 14 +++++++++++++- 3 files changed, 39 insertions(+), 3 deletions(-) diff --git a/ci/builders/linux_android_aot_engine.json b/ci/builders/linux_android_aot_engine.json index 5e03a1da05724..f79b3bf6ee197 100644 --- a/ci/builders/linux_android_aot_engine.json +++ b/ci/builders/linux_android_aot_engine.json @@ -219,5 +219,17 @@ ] } } - ] + ], + "generators": { + "tasks": [ + { + "name": "Verify-export-symbols-release-binaries", + "parameters": [ + "src/out" + ], + "script": "flutter/testing/symbols/verify_exported.dart", + "language": "dart" + } + ] + } } diff --git a/ci/builders/linux_android_debug_engine.json b/ci/builders/linux_android_debug_engine.json index 3a0de90982a49..068ed7d9ac0d7 100644 --- a/ci/builders/linux_android_debug_engine.json +++ b/ci/builders/linux_android_debug_engine.json @@ -193,5 +193,17 @@ ] } } - ] + ], + "generators": { + "tasks": [ + { + "name": "Verify-export-symbols-release-binaries", + "parameters": [ + "src/out" + ], + "script": "flutter/testing/symbols/verify_exported.dart", + "language": "dart" + } + ] + } } diff --git a/ci/builders/linux_host_engine.json b/ci/builders/linux_host_engine.json index 32e6bec92c12f..9b2e75890f714 100644 --- a/ci/builders/linux_host_engine.json +++ b/ci/builders/linux_host_engine.json @@ -225,5 +225,17 @@ } ] } - ] + ], + "generators": { + "tasks": [ + { + "name": "Verify-export-symbols-release-binaries", + "parameters": [ + "src/out" + ], + "script": "flutter/testing/symbols/verify_exported.dart", + "language": "dart" + } + ] + } } From cbe3e7ea29b09d778d8668d06e917e4f9eb3d584 Mon Sep 17 00:00:00 2001 From: Godofredo Contreras Date: Mon, 1 May 2023 11:03:25 -0700 Subject: [PATCH 2/2] Add validation to mac ios. --- ci/builders/mac_ios_engine.json | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/ci/builders/mac_ios_engine.json b/ci/builders/mac_ios_engine.json index 90d7a871f9d6f..9af381cae2ba4 100644 --- a/ci/builders/mac_ios_engine.json +++ b/ci/builders/mac_ios_engine.json @@ -163,6 +163,14 @@ ], "script": "flutter/sky/tools/create_macos_gen_snapshots.py", "language": "python3" + }, + { + "name": "Verify-export-symbols-release-binaries", + "parameters": [ + "src/out" + ], + "script": "flutter/testing/symbols/verify_exported.dart", + "language": "dart" } ] },