From 7ee7d72cd559dfb28482937503e7e024399d211e Mon Sep 17 00:00:00 2001
From: godofredoc <godofredoc@google.com>
Date: Mon, 15 May 2023 12:57:00 -0700
Subject: [PATCH] Use release_build and os dimension consistently. (#42012)

Release_build property is used to signal that this build produces release artifacts that will eventually be SLSA compliant and will need to run from dart_internal.

The os property is used to select the correct drone based on the platform the build should run on.

Bug: https://github.com/flutter/flutter/issues/126118
Bug: https://github.com/flutter/flutter/issues/125983
Bug: https://github.com/flutter/flutter/issues/126116

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
---
 .ci.yaml | 30 +++++++++++++++++++++++++++---
 1 file changed, 27 insertions(+), 3 deletions(-)

diff --git a/.ci.yaml b/.ci.yaml
index 1599708754c41..4e20b52a3bb59 100644
--- a/.ci.yaml
+++ b/.ci.yaml
@@ -262,6 +262,8 @@ targets:
     properties:
       release_build: "true"
       config_name: linux_fuchsia
+      drone_dimensions: >
+        ["os=Linux"]
 
   - name: Linux linux_arm_host_engine
     recipe: engine_v2/engine_v2
@@ -269,10 +271,14 @@ targets:
     properties:
       release_build: "true"
       config_name: linux_arm_host_engine
+      drone_dimensions: >
+        ["os=Linux"]
 
   - name: Linux linux_host_engine
     recipe: engine_v2/engine_v2
     timeout: 60
+    dimensions:
+      os: "Linux"
     properties:
       release_build: "true"
       config_name: linux_host_engine
@@ -283,6 +289,8 @@ targets:
     properties:
       release_build: "true"
       config_name: linux_host_desktop_engine
+      drone_dimensions: >
+        ["os=Linux"]
 
   - name: Linux linux_android_aot_engine
     recipe: engine_v2/engine_v2
@@ -290,6 +298,8 @@ targets:
     properties:
       release_build: "true"
       config_name: linux_android_aot_engine
+      drone_dimensions: >
+        ["os=Linux"]
 
   - name: Linux linux_android_debug_engine
     recipe: engine_v2/engine_v2
@@ -297,12 +307,13 @@ targets:
     properties:
       release_build: "true"
       config_name: linux_android_debug_engine
+      drone_dimensions: >
+        ["os=Linux"]
 
   - name: Linux linux_license
     recipe: engine_v2/builder
     timeout: 60
     properties:
-      release_build: "true"
       config_name: linux_license
       clobber: "true"
 
@@ -312,12 +323,13 @@ targets:
     properties:
       release_build: "true"
       config_name: linux_web_engine
+      drone_dimensions: >
+        ["os=Linux"]
 
   - name: Linux linux_unopt
     recipe: engine_v2/engine_v2
     timeout: 60
     properties:
-      release_build: "true"
       config_name: linux_unopt
 
   - name: Linux Web Framework tests
@@ -375,7 +387,10 @@ targets:
     recipe: engine_v2/engine_v2
     timeout: 60
     properties:
+      release_build: "true"
       config_name: mac_android_aot_engine
+      drone_dimensions: >
+        ["os=Linux"]
 
   - name: Mac mac_clang_tidy
     bringup: true
@@ -397,6 +412,8 @@ targets:
         ]
       $flutter/osx_sdk : >-
         { "sdk_version": "14e222b" }
+      drone_dimensions: >
+        ["os=Mac-12"]
 
   - name: Linux mac_unopt
     recipe: engine_v2/engine_v2
@@ -480,13 +497,14 @@ targets:
         [
           {"dependency": "jazzy", "version": "0.14.1"}
         ]
+      drone_dimensions: >
+        ["os=Mac-12"]
 
   - name: Mac impeller-cmake-example
     bringup: true
     recipe: engine_v2/engine_v2
     timeout: 60
     properties:
-      release_build: "true"
       cpu: arm64
       config_name: mac_impeller_cmake_example
 
@@ -515,6 +533,8 @@ targets:
     properties:
       release_build: "true"
       config_name: windows_android_aot_engine
+      drone_dimensions: >
+        ["os=Windows"]
 
   - name: Windows windows_host_engine
     recipe: engine_v2/engine_v2
@@ -522,6 +542,8 @@ targets:
     properties:
       release_build: "true"
       config_name: windows_host_engine
+      drone_dimensions: >
+        ["os=Windows"]
 
   - name: Windows windows_arm_host_engine
     recipe: engine_v2/engine_v2
@@ -532,6 +554,8 @@ targets:
     properties:
       release_build: "true"
       config_name: windows_arm_host_engine
+      drone_dimensions: >
+        ["os=Windows"]
 
   - name: Windows windows_unopt
     bringup: true