From 63c9bde768ea44a094d6666c553824993c3cb7ea Mon Sep 17 00:00:00 2001
From: asiva <asiva@google.com>
Date: Fri, 16 Jun 2023 16:19:20 -0700
Subject: [PATCH 1/3] Fix analyzer warnings because of the new option
 prefer_final_in_for_each being made the default.

---
 tools/clang_tidy/lib/clang_tidy.dart | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/tools/clang_tidy/lib/clang_tidy.dart b/tools/clang_tidy/lib/clang_tidy.dart
index 6fcbeb29d6e86..6e82f1e861713 100644
--- a/tools/clang_tidy/lib/clang_tidy.dart
+++ b/tools/clang_tidy/lib/clang_tidy.dart
@@ -237,13 +237,13 @@ class ClangTidy {
     final List<Command> totalCommands = <Command>[];
     if (sharedBuildCommandsData.isNotEmpty) {
       final List<Command> buildCommands = <Command>[
-        for (Object? data in buildCommandsData)
+        for (final Object? data in buildCommandsData)
           Command.fromMap((data as Map<String, Object?>?)!)
       ];
       final List<Set<String>> shardFilePaths = <Set<String>>[
-        for (List<Object?> list in sharedBuildCommandsData)
+        for (final List<Object?> list in sharedBuildCommandsData)
           <String>{
-            for (Object? data in list)
+            for (final Object? data in list)
               Command.fromMap((data as Map<String, Object?>?)!).filePath
           }
       ];
@@ -255,7 +255,7 @@ class ClangTidy {
         }
       }
       final List<Command> intersection = <Command>[
-        for (_SetStatusCommand result in intersectionResults)
+        for (final _SetStatusCommand result in intersectionResults)
           if (result.setStatus == _SetStatus.Intersection) result.command
       ];
       // Make sure to sort results so the sharding scheme is guaranteed to work
@@ -266,7 +266,7 @@ class ClangTidy {
           _takeShard(intersection, shardId!, 1 + sharedBuildCommandsData.length));
     } else {
       totalCommands.addAll(<Command>[
-        for (Object? data in buildCommandsData)
+        for (final Object? data in buildCommandsData)
           Command.fromMap((data as Map<String, Object?>?)!)
       ]);
     }

From 3292c2a0ca817cb40c6d61cb27c74d1e983ae8f2 Mon Sep 17 00:00:00 2001
From: asiva <asiva@google.com>
Date: Fri, 16 Jun 2023 16:37:07 -0700
Subject: [PATCH 2/3] Fake change.

---
 tools/clang_tidy/lib/clang_tidy.dart | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/clang_tidy/lib/clang_tidy.dart b/tools/clang_tidy/lib/clang_tidy.dart
index 6e82f1e861713..6bb5294b90b8c 100644
--- a/tools/clang_tidy/lib/clang_tidy.dart
+++ b/tools/clang_tidy/lib/clang_tidy.dart
@@ -192,7 +192,7 @@ class ClangTidy {
   /// Returns f(n) = value(n * [shardCount] + [id]).
   Iterable<T> _takeShard<T>(Iterable<T> values, int id, int shardCount) sync* {
     int count = 0;
-    for (final T val in values) {
+    for (T val in values) {
       if (count % shardCount == id) {
         yield val;
       }

From c4e254279c59b572c426b7a1db0a76a56bea44ba Mon Sep 17 00:00:00 2001
From: asiva <asiva@google.com>
Date: Fri, 16 Jun 2023 16:37:26 -0700
Subject: [PATCH 3/3] Fake commit.

---
 tools/clang_tidy/lib/clang_tidy.dart | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/clang_tidy/lib/clang_tidy.dart b/tools/clang_tidy/lib/clang_tidy.dart
index 6bb5294b90b8c..6e82f1e861713 100644
--- a/tools/clang_tidy/lib/clang_tidy.dart
+++ b/tools/clang_tidy/lib/clang_tidy.dart
@@ -192,7 +192,7 @@ class ClangTidy {
   /// Returns f(n) = value(n * [shardCount] + [id]).
   Iterable<T> _takeShard<T>(Iterable<T> values, int id, int shardCount) sync* {
     int count = 0;
-    for (T val in values) {
+    for (final T val in values) {
       if (count % shardCount == id) {
         yield val;
       }