From 4d74697d9cda72301ceb8383a939bc376c05b205 Mon Sep 17 00:00:00 2001 From: Jonah Williams Date: Wed, 21 Jun 2023 13:51:48 -0700 Subject: [PATCH] Revert "[Impeller] dont use concurrent runner to decode images on Android. (#42944)" This reverts commit 0f36b184fb598fd90290c5477651eda188e5f3c8. --- lib/ui/painting/image_decoder_impeller.cc | 18 +++++------------- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/lib/ui/painting/image_decoder_impeller.cc b/lib/ui/painting/image_decoder_impeller.cc index 3902ca762b29a..ecb455c1bdaa0 100644 --- a/lib/ui/painting/image_decoder_impeller.cc +++ b/lib/ui/painting/image_decoder_impeller.cc @@ -456,11 +456,7 @@ void ImageDecoderImpeller::Decode(fml::RefPtr descriptor, }); }; -#ifdef FML_OS_ANDROID - runners_.GetIOTaskRunner()->PostTask( -#else concurrent_task_runner_->PostTask( -#endif [raw_descriptor, // context = context_.get(), // target_size = SkISize::Make(target_width, target_height), // @@ -499,16 +495,12 @@ void ImageDecoderImpeller::Decode(fml::RefPtr descriptor, result(image, decode_error); } }; -// TODO(jonahwilliams): -// https://github.com/flutter/flutter/issues/123058 Technically we -// don't need to post tasks to the io runner, but without this -// forced serialization we can end up overloading the GPU and/or -// competing with raster workloads. -#ifdef FML_OS_ANDROID - upload_texture_and_invoke_result(); -#else + // TODO(jonahwilliams): + // https://github.com/flutter/flutter/issues/123058 Technically we + // don't need to post tasks to the io runner, but without this + // forced serialization we can end up overloading the GPU and/or + // competing with raster workloads. io_runner->PostTask(upload_texture_and_invoke_result); -#endif }); }