From 0f1a745967a89c5138bb731da146116edab6d4f6 Mon Sep 17 00:00:00 2001 From: Aaron Clarke Date: Tue, 1 Aug 2023 10:35:11 -0700 Subject: [PATCH 1/4] Made the licenses output all problems --- ci/licenses.sh | 4 ++-- impeller/renderer/foo.cc | 1 + impeller/renderer/foo.h | 1 + impeller/renderer/foo_unittests.cc | 1 + 4 files changed, 5 insertions(+), 2 deletions(-) create mode 100644 impeller/renderer/foo.cc create mode 100644 impeller/renderer/foo.h create mode 100644 impeller/renderer/foo_unittests.cc diff --git a/ci/licenses.sh b/ci/licenses.sh index 8d6e2c6093983..2108c1be271f9 100755 --- a/ci/licenses.sh +++ b/ci/licenses.sh @@ -65,7 +65,7 @@ dart --version # Runs the tests for the license script. function run_tests() ( cd "$SRC_DIR/flutter/tools/licenses" - find -name "*_test.dart" | xargs -n 1 dart --enable-asserts + find . -name "*_test.dart" | xargs -n 1 dart --enable-asserts ) # Collects the license information from the repo. @@ -91,7 +91,7 @@ function verify_licenses() ( cd "$SRC_DIR" # These files trip up the script on Mac OS X. - find . -name ".DS_Store" -exec rm {} \; + find . -name ".DS_Store" -exec rm -f {} \; collect_licenses diff --git a/impeller/renderer/foo.cc b/impeller/renderer/foo.cc new file mode 100644 index 0000000000000..5757cd48ace5e --- /dev/null +++ b/impeller/renderer/foo.cc @@ -0,0 +1 @@ +// foo.cc diff --git a/impeller/renderer/foo.h b/impeller/renderer/foo.h new file mode 100644 index 0000000000000..249664863bd2e --- /dev/null +++ b/impeller/renderer/foo.h @@ -0,0 +1 @@ +// foo.h diff --git a/impeller/renderer/foo_unittests.cc b/impeller/renderer/foo_unittests.cc new file mode 100644 index 0000000000000..6f854efc5f2cb --- /dev/null +++ b/impeller/renderer/foo_unittests.cc @@ -0,0 +1 @@ +// foo_unittests.cc From bf52ed281b7b49c3272f5e86af7666ab690e937e Mon Sep 17 00:00:00 2001 From: Aaron Clarke Date: Tue, 1 Aug 2023 10:53:52 -0700 Subject: [PATCH 2/4] removed set -e --- ci/licenses.sh | 1 - 1 file changed, 1 deletion(-) diff --git a/ci/licenses.sh b/ci/licenses.sh index 2108c1be271f9..670d43044679a 100755 --- a/ci/licenses.sh +++ b/ci/licenses.sh @@ -4,7 +4,6 @@ # Use of this source code is governed by a BSD-style license that can be # found in the LICENSE file. -set -e shopt -s nullglob # Needed because if it is set, cd may print the path it changed to. From 291fb10d9359090f1e678ee66fe60380e73d4a35 Mon Sep 17 00:00:00 2001 From: Aaron Clarke Date: Tue, 1 Aug 2023 11:04:57 -0700 Subject: [PATCH 3/4] removed test files --- impeller/renderer/foo.cc | 1 - impeller/renderer/foo.h | 1 - impeller/renderer/foo_unittests.cc | 1 - 3 files changed, 3 deletions(-) delete mode 100644 impeller/renderer/foo.cc delete mode 100644 impeller/renderer/foo.h delete mode 100644 impeller/renderer/foo_unittests.cc diff --git a/impeller/renderer/foo.cc b/impeller/renderer/foo.cc deleted file mode 100644 index 5757cd48ace5e..0000000000000 --- a/impeller/renderer/foo.cc +++ /dev/null @@ -1 +0,0 @@ -// foo.cc diff --git a/impeller/renderer/foo.h b/impeller/renderer/foo.h deleted file mode 100644 index 249664863bd2e..0000000000000 --- a/impeller/renderer/foo.h +++ /dev/null @@ -1 +0,0 @@ -// foo.h diff --git a/impeller/renderer/foo_unittests.cc b/impeller/renderer/foo_unittests.cc deleted file mode 100644 index 6f854efc5f2cb..0000000000000 --- a/impeller/renderer/foo_unittests.cc +++ /dev/null @@ -1 +0,0 @@ -// foo_unittests.cc From bab4f302c9b868c97c803e242f6421845a29f9d3 Mon Sep 17 00:00:00 2001 From: Aaron Clarke Date: Tue, 1 Aug 2023 11:13:48 -0700 Subject: [PATCH 4/4] added comment --- ci/licenses.sh | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ci/licenses.sh b/ci/licenses.sh index 670d43044679a..c38b08126996d 100755 --- a/ci/licenses.sh +++ b/ci/licenses.sh @@ -4,6 +4,9 @@ # Use of this source code is governed by a BSD-style license that can be # found in the LICENSE file. +# Do not exit when a non-zero return value is encountered to output all errors. +# See: https://github.com/flutter/flutter/issues/131680 +# set -e shopt -s nullglob # Needed because if it is set, cd may print the path it changed to.