From 8ea4d780addd92e3eda1fa99a45add8c151c0d90 Mon Sep 17 00:00:00 2001 From: eriko13 Date: Fri, 29 Sep 2023 16:40:56 -0700 Subject: [PATCH 1/2] fixed web autofill name tanslation for "middleName" --- lib/web_ui/lib/src/engine/text_editing/autofill_hint.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/web_ui/lib/src/engine/text_editing/autofill_hint.dart b/lib/web_ui/lib/src/engine/text_editing/autofill_hint.dart index 7ee1cfb732431..392998111c048 100644 --- a/lib/web_ui/lib/src/engine/text_editing/autofill_hint.dart +++ b/lib/web_ui/lib/src/engine/text_editing/autofill_hint.dart @@ -33,7 +33,7 @@ class BrowserAutofillHints { 'impp': 'impp', 'jobTitle': 'organization-title', 'language': 'language', - 'middleName': 'middleName', + 'middleName': 'additional-name', 'name': 'name', 'namePrefix': 'honorific-prefix', 'nameSuffix': 'honorific-suffix', From 27581f704aebb4f5c9103591c51fd1bb80bcfa1c Mon Sep 17 00:00:00 2001 From: Erik German Date: Sat, 30 Sep 2023 16:22:33 -0700 Subject: [PATCH 2/2] added regression test for 135542 --- lib/web_ui/test/engine/text_editing_test.dart | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/lib/web_ui/test/engine/text_editing_test.dart b/lib/web_ui/test/engine/text_editing_test.dart index 1c3df325cd450..a6e5f02c0a33b 100644 --- a/lib/web_ui/test/engine/text_editing_test.dart +++ b/lib/web_ui/test/engine/text_editing_test.dart @@ -2614,6 +2614,12 @@ Future testMain() async { expect(testInputElement.getAttribute('autocomplete'),'on'); expect(testInputElement.placeholder, 'enter your password'); }); + + // Regression test for https://github.com/flutter/flutter/issues/135542 + test('autofill with middleName hint', () { + expect(BrowserAutofillHints.instance.flutterToEngine('middleName'), + 'additional-name'); + }); }); group('EditingState', () {