From 452b2b49f261fb5a3f62c706b4d8820f5a6daf65 Mon Sep 17 00:00:00 2001
From: Yegor Jbanov <yjbanov@google.com>
Date: Fri, 27 Oct 2023 18:05:32 -0700
Subject: [PATCH 1/2] [web] remove ulimit and add -i to felt

---
 lib/web_ui/dev/felt | 70 ++++++++++++++++++---------------------------
 1 file changed, 28 insertions(+), 42 deletions(-)

diff --git a/lib/web_ui/dev/felt b/lib/web_ui/dev/felt
index 00062b705b37a..5c45c76232ff8 100755
--- a/lib/web_ui/dev/felt
+++ b/lib/web_ui/dev/felt
@@ -14,6 +14,29 @@ ENGINE_SRC_DIR="$(dirname $(dirname $(dirname $(dirname ${FELT_DIR}))))"
 FLUTTER_DIR="${ENGINE_SRC_DIR}/flutter"
 SDK_PREBUILTS_DIR="${FLUTTER_DIR}/prebuilts"
 
+# If set to 0 (the default) will run felt non-incrementally. For example, it will
+# run pub get.
+# If set to 1 (via the -i option) will run felt incrementally.
+INCREMENTAL=0
+
+# All arguments passed to felt, expect -i, if any.
+ARGS=""
+for arg in "$@" ; do
+  case "$arg" in
+    -i)
+      INCREMENTAL=1
+      shift
+      ;;
+    *)
+      ARGS="${ARGS} ${arg}"
+      ;;
+  esac
+done
+
+echo $INCREMENTAL
+echo $ARGS
+exit 0
+
 if [ -z "${DART_SDK_DIR}" ]
 then
   if [[ $KERNEL_NAME == *"Darwin"* ]]
@@ -50,7 +73,7 @@ then
 
 else
   if [ ! -d "$DART_SDK_DIR" ]
-  then 
+  then
     echo "Explicitly specified dart SDK not found at ${DART_SDK_DIR}."
     exit 1
   fi
@@ -84,47 +107,10 @@ install_deps() {
   (cd "$WEB_UI_DIR"; silent_on_success $DART_PATH pub get)
 }
 
-if [[ $KERNEL_NAME == *"Darwin"* ]]
+cd $WEB_UI_DIR
+if [[ "$INCREMENTAL" == "0" ]]
 then
-  echo "Running on MacOS. Will check the file and user limits."
-  # Disable exit if the commands fails. We want to give more actionable
-  # error message.
-  set +e
-  ULIMIT_FILES=`ulimit -n`
-  # Increase the file limit if it is low. Note that these limits are changed
-  # only for this script (for this shell). After felt execution is completed
-  # no change is required to reset the original shell.
-  if [[ $ULIMIT_FILES -lt 50000 ]]
-  then
-    echo "File limits too low increasing the file limits"
-    # Get the max file limit.
-    MAX_ULIMIT_FILES=`launchctl limit maxfiles | sed -e 's/^[[:space:]]*//' | sed 's/ \{1,\}/ /g' | cut -d' ' -f2`
-    if [[ $MAX_ULIMIT_FILES -lt 50000 ]]
-    then
-      # Increase the maximum file limit.
-      sudo launchctl limit maxfiles 50000 200000
-    fi
-    ERROR=$(ulimit -n 50000 2>&1 >/dev/null)
-    if [[ ! -z $ERROR ]]
-    then
-      echo "Problem changing the file limit. Please try to reboot to use the higher limits. error: \n$ERROR" 1>&2
-    fi
-  fi
-  ULIMIT_USER=`ulimit -u`
-  # Increase the hard user limit if it is lower than 2048.
-  if [[ $ULIMIT_USER -lt 4096 ]]
-  then
-    echo "User limits too low increasing the user limits"
-    ERROR2=$(ulimit -u 4096 2>&1 >/dev/null)
-    if [[ ! -z $ERROR2 ]]
-    then
-      echo "Problem changing the user limit. Please try to reboot to use the higher limits. error: \n$ERROR2" 1>&2
-    fi
-  fi
-  # Set the value back to exit on non zero results.
-  set -e
+  install_deps
 fi
 
-cd $WEB_UI_DIR
-install_deps
-(cd $WEB_UI_DIR && $DART_SDK_DIR/bin/dart run $FELT_DEBUG_FLAGS dev/felt.dart $@)
+(cd $WEB_UI_DIR && $DART_SDK_DIR/bin/dart run $FELT_DEBUG_FLAGS dev/felt.dart ${ARGS})

From 4100acad023c4c9d9bc840f725bc08dc4303152c Mon Sep 17 00:00:00 2001
From: Yegor Jbanov <yjbanov@google.com>
Date: Fri, 1 Dec 2023 20:24:22 -0800
Subject: [PATCH 2/2] address comment; remove print debugging

---
 lib/web_ui/dev/felt | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/lib/web_ui/dev/felt b/lib/web_ui/dev/felt
index 5c45c76232ff8..0f2a751a35495 100755
--- a/lib/web_ui/dev/felt
+++ b/lib/web_ui/dev/felt
@@ -19,7 +19,7 @@ SDK_PREBUILTS_DIR="${FLUTTER_DIR}/prebuilts"
 # If set to 1 (via the -i option) will run felt incrementally.
 INCREMENTAL=0
 
-# All arguments passed to felt, expect -i, if any.
+# All arguments passed to felt, except -i, if any.
 ARGS=""
 for arg in "$@" ; do
   case "$arg" in
@@ -33,10 +33,6 @@ for arg in "$@" ; do
   esac
 done
 
-echo $INCREMENTAL
-echo $ARGS
-exit 0
-
 if [ -z "${DART_SDK_DIR}" ]
 then
   if [[ $KERNEL_NAME == *"Darwin"* ]]