From fc8dee930b4bc80c7e3bf9562dc50a9fb68afb15 Mon Sep 17 00:00:00 2001
From: Aaron Clarke <aaclarke@google.com>
Date: Mon, 27 Nov 2023 11:14:34 -0800
Subject: [PATCH] [Impeller] updated gaussian blur tests to use device private
 textures

---
 .../directional_gaussian_blur_filter_contents_unittests.cc | 1 +
 .../filters/gaussian_blur_filter_contents_unittests.cc     | 7 +++++++
 2 files changed, 8 insertions(+)

diff --git a/impeller/entity/contents/filters/directional_gaussian_blur_filter_contents_unittests.cc b/impeller/entity/contents/filters/directional_gaussian_blur_filter_contents_unittests.cc
index c91ae493f9bac..7493a8126bb81 100644
--- a/impeller/entity/contents/filters/directional_gaussian_blur_filter_contents_unittests.cc
+++ b/impeller/entity/contents/filters/directional_gaussian_blur_filter_contents_unittests.cc
@@ -89,6 +89,7 @@ TEST_P(DirectionalGaussianBlurFilterContentsTest, RenderNoCoverage) {
 TEST_P(DirectionalGaussianBlurFilterContentsTest,
        RenderCoverageMatchesGetCoverage) {
   TextureDescriptor desc = {
+      .storage_mode = StorageMode::kDevicePrivate,
       .format = PixelFormat::kB8G8R8A8UNormInt,
       .size = ISize(100, 100),
   };
diff --git a/impeller/entity/contents/filters/gaussian_blur_filter_contents_unittests.cc b/impeller/entity/contents/filters/gaussian_blur_filter_contents_unittests.cc
index d8378d35dc560..55ccd334c987b 100644
--- a/impeller/entity/contents/filters/gaussian_blur_filter_contents_unittests.cc
+++ b/impeller/entity/contents/filters/gaussian_blur_filter_contents_unittests.cc
@@ -70,6 +70,7 @@ TEST(GaussianBlurFilterContentsTest, CoverageWithSigma) {
 
 TEST_P(GaussianBlurFilterContentsTest, CoverageWithTexture) {
   TextureDescriptor desc = {
+      .storage_mode = StorageMode::kDevicePrivate,
       .format = PixelFormat::kB8G8R8A8UNormInt,
       .size = ISize(100, 100),
   };
@@ -88,6 +89,7 @@ TEST_P(GaussianBlurFilterContentsTest, CoverageWithTexture) {
 
 TEST_P(GaussianBlurFilterContentsTest, CoverageWithEffectTransform) {
   TextureDescriptor desc = {
+      .storage_mode = StorageMode::kDevicePrivate,
       .format = PixelFormat::kB8G8R8A8UNormInt,
       .size = ISize(100, 100),
   };
@@ -115,6 +117,7 @@ TEST(GaussianBlurFilterContentsTest, FilterSourceCoverage) {
 
 TEST_P(GaussianBlurFilterContentsTest, RenderCoverageMatchesGetCoverage) {
   TextureDescriptor desc = {
+      .storage_mode = StorageMode::kDevicePrivate,
       .format = PixelFormat::kB8G8R8A8UNormInt,
       .size = ISize(100, 100),
   };
@@ -146,6 +149,7 @@ TEST_P(GaussianBlurFilterContentsTest, RenderCoverageMatchesGetCoverage) {
 TEST_P(GaussianBlurFilterContentsTest,
        RenderCoverageMatchesGetCoverageTranslate) {
   TextureDescriptor desc = {
+      .storage_mode = StorageMode::kDevicePrivate,
       .format = PixelFormat::kB8G8R8A8UNormInt,
       .size = ISize(100, 100),
   };
@@ -159,6 +163,7 @@ TEST_P(GaussianBlurFilterContentsTest,
   entity.SetTransform(Matrix::MakeTranslation({100, 200, 0}));
   std::optional<Entity> result =
       contents->GetEntity(*renderer, entity, /*coverage_hint=*/{});
+
   EXPECT_TRUE(result.has_value());
   if (result.has_value()) {
     EXPECT_EQ(result.value().GetBlendMode(), BlendMode::kSourceOver);
@@ -178,6 +183,7 @@ TEST_P(GaussianBlurFilterContentsTest,
 TEST_P(GaussianBlurFilterContentsTest,
        RenderCoverageMatchesGetCoverageRotated) {
   TextureDescriptor desc = {
+      .storage_mode = StorageMode::kDevicePrivate,
       .format = PixelFormat::kB8G8R8A8UNormInt,
       .size = ISize(400, 300),
   };
@@ -210,6 +216,7 @@ TEST_P(GaussianBlurFilterContentsTest,
 
 TEST_P(GaussianBlurFilterContentsTest, CalculateUVsSimple) {
   TextureDescriptor desc = {
+      .storage_mode = StorageMode::kDevicePrivate,
       .format = PixelFormat::kB8G8R8A8UNormInt,
       .size = ISize(100, 100),
   };