From 3a5e461817b5f34ec4b7155a115c1373f639094c Mon Sep 17 00:00:00 2001 From: Jenn Magder Date: Thu, 14 Dec 2023 17:43:07 -0800 Subject: [PATCH 1/3] Turn on scenario app screenshots --- .../xcshareddata/xcschemes/IosUnitTests.xcscheme | 3 +-- .../xcshareddata/xcschemes/Scenarios.xcscheme | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/testing/ios/IosUnitTests/IosUnitTests.xcodeproj/xcshareddata/xcschemes/IosUnitTests.xcscheme b/testing/ios/IosUnitTests/IosUnitTests.xcodeproj/xcshareddata/xcschemes/IosUnitTests.xcscheme index b1341fc8d5c2a..cb0776ee41f7b 100644 --- a/testing/ios/IosUnitTests/IosUnitTests.xcodeproj/xcshareddata/xcschemes/IosUnitTests.xcscheme +++ b/testing/ios/IosUnitTests/IosUnitTests.xcodeproj/xcshareddata/xcschemes/IosUnitTests.xcscheme @@ -26,8 +26,7 @@ buildConfiguration = "Debug" selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB" selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB" - shouldUseLaunchSchemeArgsEnv = "YES" - systemAttachmentLifetime = "keepNever"> + shouldUseLaunchSchemeArgsEnv = "YES"> + shouldUseLaunchSchemeArgsEnv = "YES"> Date: Thu, 14 Dec 2023 17:44:56 -0800 Subject: [PATCH 2/3] Fail to see screenshots --- .../ios/Scenarios/ScenariosUITests/BogusFontTextTest.m | 2 +- .../ios/Scenarios/ScenariosUITests/DarwinSystemFontTests.m | 2 +- .../ios/Scenarios/ScenariosUITests/iPadGestureTests.m | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/testing/scenario_app/ios/Scenarios/ScenariosUITests/BogusFontTextTest.m b/testing/scenario_app/ios/Scenarios/ScenariosUITests/BogusFontTextTest.m index dc554ae2e5986..0f0ec85a79674 100644 --- a/testing/scenario_app/ios/Scenarios/ScenariosUITests/BogusFontTextTest.m +++ b/testing/scenario_app/ios/Scenarios/ScenariosUITests/BogusFontTextTest.m @@ -22,7 +22,7 @@ - (void)testFontRenderingWhenSuppliedWithBogusFont { [application launch]; XCUIElement* addTextField = application.textFields[@"ready"]; - XCTAssertTrue([addTextField waitForExistenceWithTimeout:30]); + XCTAssertFalse([addTextField waitForExistenceWithTimeout:30]); GoldenTestManager* manager = [[GoldenTestManager alloc] initWithLaunchArg:@"--bogus-font-text"]; [manager checkGoldenForTest:self rmesThreshold:kDefaultRmseThreshold]; diff --git a/testing/scenario_app/ios/Scenarios/ScenariosUITests/DarwinSystemFontTests.m b/testing/scenario_app/ios/Scenarios/ScenariosUITests/DarwinSystemFontTests.m index 29fec251557ed..4356725773aa6 100644 --- a/testing/scenario_app/ios/Scenarios/ScenariosUITests/DarwinSystemFontTests.m +++ b/testing/scenario_app/ios/Scenarios/ScenariosUITests/DarwinSystemFontTests.m @@ -20,7 +20,7 @@ - (void)testFontRendering { [application launch]; XCUIElement* addTextField = application.textFields[@"ready"]; - XCTAssertTrue([addTextField waitForExistenceWithTimeout:30]); + XCTAssertFalse([addTextField waitForExistenceWithTimeout:30]); GoldenTestManager* manager = [[GoldenTestManager alloc] initWithLaunchArg:@"--darwin-system-font"]; diff --git a/testing/scenario_app/ios/Scenarios/ScenariosUITests/iPadGestureTests.m b/testing/scenario_app/ios/Scenarios/ScenariosUITests/iPadGestureTests.m index 71f5a88796d76..c5ca2afb629c1 100644 --- a/testing/scenario_app/ios/Scenarios/ScenariosUITests/iPadGestureTests.m +++ b/testing/scenario_app/ios/Scenarios/ScenariosUITests/iPadGestureTests.m @@ -65,7 +65,7 @@ - (void)testPointerButtons { [flutterView tap]; // Initial add event should have buttons = 0 - XCTAssertTrue( + XCTAssertFalse( [app.textFields[@"0,PointerChange.add,device=0,buttons=0"] waitForExistenceWithTimeout:1], @"PointerChange.add event did not occur for a normal tap"); // Normal tap should have buttons = 0, the flutter framework will ensure it has buttons = 1 From a706a4d11a4cca2dfa2e597a698b2929f9598f51 Mon Sep 17 00:00:00 2001 From: Jenn Magder Date: Thu, 14 Dec 2023 18:39:04 -0800 Subject: [PATCH 3/3] Revert "Fail to see screenshots" This reverts commit a49c3bbfbce91e4d3a0c6f70bee90230bb6926b1. --- .../ios/Scenarios/ScenariosUITests/BogusFontTextTest.m | 2 +- .../ios/Scenarios/ScenariosUITests/DarwinSystemFontTests.m | 2 +- .../ios/Scenarios/ScenariosUITests/iPadGestureTests.m | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/testing/scenario_app/ios/Scenarios/ScenariosUITests/BogusFontTextTest.m b/testing/scenario_app/ios/Scenarios/ScenariosUITests/BogusFontTextTest.m index 0f0ec85a79674..dc554ae2e5986 100644 --- a/testing/scenario_app/ios/Scenarios/ScenariosUITests/BogusFontTextTest.m +++ b/testing/scenario_app/ios/Scenarios/ScenariosUITests/BogusFontTextTest.m @@ -22,7 +22,7 @@ - (void)testFontRenderingWhenSuppliedWithBogusFont { [application launch]; XCUIElement* addTextField = application.textFields[@"ready"]; - XCTAssertFalse([addTextField waitForExistenceWithTimeout:30]); + XCTAssertTrue([addTextField waitForExistenceWithTimeout:30]); GoldenTestManager* manager = [[GoldenTestManager alloc] initWithLaunchArg:@"--bogus-font-text"]; [manager checkGoldenForTest:self rmesThreshold:kDefaultRmseThreshold]; diff --git a/testing/scenario_app/ios/Scenarios/ScenariosUITests/DarwinSystemFontTests.m b/testing/scenario_app/ios/Scenarios/ScenariosUITests/DarwinSystemFontTests.m index 4356725773aa6..29fec251557ed 100644 --- a/testing/scenario_app/ios/Scenarios/ScenariosUITests/DarwinSystemFontTests.m +++ b/testing/scenario_app/ios/Scenarios/ScenariosUITests/DarwinSystemFontTests.m @@ -20,7 +20,7 @@ - (void)testFontRendering { [application launch]; XCUIElement* addTextField = application.textFields[@"ready"]; - XCTAssertFalse([addTextField waitForExistenceWithTimeout:30]); + XCTAssertTrue([addTextField waitForExistenceWithTimeout:30]); GoldenTestManager* manager = [[GoldenTestManager alloc] initWithLaunchArg:@"--darwin-system-font"]; diff --git a/testing/scenario_app/ios/Scenarios/ScenariosUITests/iPadGestureTests.m b/testing/scenario_app/ios/Scenarios/ScenariosUITests/iPadGestureTests.m index c5ca2afb629c1..71f5a88796d76 100644 --- a/testing/scenario_app/ios/Scenarios/ScenariosUITests/iPadGestureTests.m +++ b/testing/scenario_app/ios/Scenarios/ScenariosUITests/iPadGestureTests.m @@ -65,7 +65,7 @@ - (void)testPointerButtons { [flutterView tap]; // Initial add event should have buttons = 0 - XCTAssertFalse( + XCTAssertTrue( [app.textFields[@"0,PointerChange.add,device=0,buttons=0"] waitForExistenceWithTimeout:1], @"PointerChange.add event did not occur for a normal tap"); // Normal tap should have buttons = 0, the flutter framework will ensure it has buttons = 1