From 4e2ccbe2e9b2da88f2164439c2d1ba902c02868c Mon Sep 17 00:00:00 2001 From: Matan Lurey Date: Mon, 11 Mar 2024 10:42:37 -0700 Subject: [PATCH] Conditionally run golden_tests_harvester for run_impeller_Golden_testes. --- testing/run_tests.py | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/testing/run_tests.py b/testing/run_tests.py index 5003b37222763..3617937f9f33a 100755 --- a/testing/run_tests.py +++ b/testing/run_tests.py @@ -1052,6 +1052,16 @@ def run_impeller_golden_tests(build_dir: str): print(diff_result.stdout.decode()) raise RuntimeError('impeller_golden_tests diff failure') + # On release builds and local builds, we typically do not have GOLDCTL set, + # which on other words means that this invoking the SkiaGoldClient would + # throw. Skip this step in those cases and log a notice. + if 'GOLDCTL' not in os.environ: + print_divider('<') + print( + 'Skipping the SkiaGoldClient invocation as the GOLDCTL environment variable is not set.' + ) + return + with DirectoryChange(harvester_path): bin_path = Path('.').joinpath('bin').joinpath('golden_tests_harvester.dart') run_cmd([dart_bin, 'run', str(bin_path), temp_dir])