From bd6f78f8a80d06dfc45b426716683abe47038a9d Mon Sep 17 00:00:00 2001 From: Mouad Debbar Date: Wed, 27 Mar 2024 13:20:25 -0400 Subject: [PATCH 1/2] Prevent `solo: true` from being committed --- lib/web_ui/analysis_options.yaml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/lib/web_ui/analysis_options.yaml b/lib/web_ui/analysis_options.yaml index 383ab4d7b0ec6..a840680ab72e1 100644 --- a/lib/web_ui/analysis_options.yaml +++ b/lib/web_ui/analysis_options.yaml @@ -6,6 +6,12 @@ include: ../../analysis_options.yaml +analyzer: + errors: + # We need this in the web engine in order to prevent committing `solo: true` + # in tests. + deprecated_member_use: true + linter: rules: avoid_dynamic_calls: false From d1ae41af7548081db3b1c8874810b443c684b2f2 Mon Sep 17 00:00:00 2001 From: Mouad Debbar Date: Thu, 28 Mar 2024 14:38:02 -0400 Subject: [PATCH 2/2] add ignore --- lib/web_ui/dev/test_platform.dart | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/web_ui/dev/test_platform.dart b/lib/web_ui/dev/test_platform.dart index 078b18ee86322..edcc4adb86dfd 100644 --- a/lib/web_ui/dev/test_platform.dart +++ b/lib/web_ui/dev/test_platform.dart @@ -22,6 +22,7 @@ import 'package:shelf_web_socket/shelf_web_socket.dart'; import 'package:skia_gold_client/skia_gold_client.dart'; import 'package:stream_channel/stream_channel.dart'; +// ignore: deprecated_member_use import 'package:test_core/backend.dart' hide Compiler; // TODO(ditman): Fix ignores when https://github.com/flutter/flutter/issues/143599 is resolved. import 'package:test_core/src/runner/environment.dart'; // ignore: implementation_imports