From f937bf7134c1fc98061e53a48ae25b10269e289b Mon Sep 17 00:00:00 2001 From: Chris Bracken Date: Tue, 23 Apr 2024 15:15:39 -0700 Subject: [PATCH] [macOS] Disable FlutterEngineTest.BackgroundColor This was re-enabled in https://github.com/flutter/flutter/issues/124677 after fixing leaks in https://github.com/flutter/engine/pull/50832. Since this test involves an NSWindow, there are separate fixes that should be landed to reduce flakes related to lack of NSWindow close calls in the tests. See related AppKit bug report filed at http://www.openradar.me/FB13291861. Issue: https://github.com/flutter/flutter/issues/145728 Related issue: https://github.com/flutter/flutter/issues/124677 --- .../platform/darwin/macos/framework/Source/FlutterEngineTest.mm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/shell/platform/darwin/macos/framework/Source/FlutterEngineTest.mm b/shell/platform/darwin/macos/framework/Source/FlutterEngineTest.mm index ffb4d9b2eda50..8bd661ef6ccd4 100644 --- a/shell/platform/darwin/macos/framework/Source/FlutterEngineTest.mm +++ b/shell/platform/darwin/macos/framework/Source/FlutterEngineTest.mm @@ -223,7 +223,7 @@ @implementation MockableFlutterEngine EXPECT_TRUE(stdout_capture.GetOutput().find("Hello logging") != std::string::npos); } -TEST_F(FlutterEngineTest, BackgroundIsBlack) { +TEST_F(FlutterEngineTest, DISABLED_BackgroundIsBlack) { FlutterEngine* engine = GetFlutterEngine(); // Latch to ensure the entire layer tree has been generated and presented.