From ca13e5a5a8cd03df0b4f3789d6d10887e592f155 Mon Sep 17 00:00:00 2001 From: Bartek Pacia Date: Sat, 27 Apr 2024 14:52:48 +0200 Subject: [PATCH 1/2] SemanticsUpdateBuilder.updateNode(): make TextDirection non-nullable --- lib/ui/semantics.dart | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/ui/semantics.dart b/lib/ui/semantics.dart index e0da396d8ec58..667d4d19ea2d2 100644 --- a/lib/ui/semantics.dart +++ b/lib/ui/semantics.dart @@ -818,7 +818,7 @@ abstract class SemanticsUpdateBuilder { required String hint, required List hintAttributes, required String tooltip, - required TextDirection? textDirection, + required TextDirection textDirection, required Float64List transform, required Int32List childrenInTraversalOrder, required Int32List childrenInHitTestOrder, @@ -888,7 +888,7 @@ base class _NativeSemanticsUpdateBuilder extends NativeFieldWrapperClass1 implem required String hint, required List hintAttributes, required String tooltip, - required TextDirection? textDirection, + required TextDirection textDirection, required Float64List transform, required Int32List childrenInTraversalOrder, required Int32List childrenInHitTestOrder, From 3fd9547671b3279796c301ef831fe61e728e8008 Mon Sep 17 00:00:00 2001 From: Bartek Pacia Date: Sat, 27 Apr 2024 20:10:35 +0200 Subject: [PATCH 2/2] semantics.dart: remove unnecessary conditions --- lib/ui/semantics.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/ui/semantics.dart b/lib/ui/semantics.dart index 667d4d19ea2d2..9167ae60d0f78 100644 --- a/lib/ui/semantics.dart +++ b/lib/ui/semantics.dart @@ -927,7 +927,7 @@ base class _NativeSemanticsUpdateBuilder extends NativeFieldWrapperClass1 implem hint, hintAttributes, tooltip, - textDirection != null ? textDirection.index + 1 : 0, + textDirection.index + 1, transform, childrenInTraversalOrder, childrenInHitTestOrder,