From ba9389cfc03b1bad2d9b778d38a8feda28d66a08 Mon Sep 17 00:00:00 2001 From: Jonah Williams Date: Fri, 7 Jun 2024 08:04:50 -0700 Subject: [PATCH] Revert "Widen CPU affinity set. (#53136)" This reverts commit 926b2928aae5f3c27f6a05df75a27f746a755834. --- fml/cpu_affinity.cc | 4 ---- fml/cpu_affinity.h | 4 ---- fml/cpu_affinity_unittests.cc | 3 --- shell/platform/android/android_shell_holder.cc | 4 ++-- 4 files changed, 2 insertions(+), 13 deletions(-) diff --git a/fml/cpu_affinity.cc b/fml/cpu_affinity.cc index 0342c85f0433e..ccb2e89686581 100644 --- a/fml/cpu_affinity.cc +++ b/fml/cpu_affinity.cc @@ -58,8 +58,6 @@ CPUSpeedTracker::CPUSpeedTracker(std::vector data) } if (data.speed == min_speed_value) { efficiency_.push_back(data.index); - } else { - not_efficiency_.push_back(data.index); } } @@ -79,8 +77,6 @@ const std::vector& CPUSpeedTracker::GetIndices( return efficiency_; case CpuAffinity::kNotPerformance: return not_performance_; - case CpuAffinity::kNotEfficiency: - return not_efficiency_; } } diff --git a/fml/cpu_affinity.h b/fml/cpu_affinity.h index c1d8498e6524a..b4c54c7bbf187 100644 --- a/fml/cpu_affinity.h +++ b/fml/cpu_affinity.h @@ -26,9 +26,6 @@ enum class CpuAffinity { /// @brief Request affinity for all non-performance cores. kNotPerformance, - - /// @brief Request affinity for all non-efficiency cores. - kNotEfficiency, }; /// @brief Request count of efficiency cores. @@ -82,7 +79,6 @@ class CPUSpeedTracker { std::vector efficiency_; std::vector performance_; std::vector not_performance_; - std::vector not_efficiency_; }; /// @note Visible for testing. diff --git a/fml/cpu_affinity_unittests.cc b/fml/cpu_affinity_unittests.cc index 142fc84612c29..8a5c90687ed24 100644 --- a/fml/cpu_affinity_unittests.cc +++ b/fml/cpu_affinity_unittests.cc @@ -29,9 +29,6 @@ TEST(CpuAffinity, NormalSlowMedFastCores) { ASSERT_EQ(tracker.GetIndices(CpuAffinity::kNotPerformance).size(), 2u); ASSERT_EQ(tracker.GetIndices(CpuAffinity::kNotPerformance)[0], 0u); ASSERT_EQ(tracker.GetIndices(CpuAffinity::kNotPerformance)[1], 1u); - ASSERT_EQ(tracker.GetIndices(CpuAffinity::kNotEfficiency).size(), 2u); - ASSERT_EQ(tracker.GetIndices(CpuAffinity::kNotEfficiency)[0], 1u); - ASSERT_EQ(tracker.GetIndices(CpuAffinity::kNotEfficiency)[1], 2u); } TEST(CpuAffinity, NoCpuData) { diff --git a/shell/platform/android/android_shell_holder.cc b/shell/platform/android/android_shell_holder.cc index 1ac761e34702b..3f425b73a62d5 100644 --- a/shell/platform/android/android_shell_holder.cc +++ b/shell/platform/android/android_shell_holder.cc @@ -49,14 +49,14 @@ static void AndroidPlatformThreadConfigSetter( break; } case fml::Thread::ThreadPriority::kDisplay: { - fml::RequestAffinity(fml::CpuAffinity::kNotEfficiency); + fml::RequestAffinity(fml::CpuAffinity::kPerformance); if (::setpriority(PRIO_PROCESS, 0, -1) != 0) { FML_LOG(ERROR) << "Failed to set UI task runner priority"; } break; } case fml::Thread::ThreadPriority::kRaster: { - fml::RequestAffinity(fml::CpuAffinity::kNotEfficiency); + fml::RequestAffinity(fml::CpuAffinity::kPerformance); // Android describes -8 as "most important display threads, for // compositing the screen and retrieving input events". Conservatively // set the raster thread to slightly lower priority than it.