From 1727342671b9e79e43951b289153983ac0d798c7 Mon Sep 17 00:00:00 2001 From: jonahwilliams Date: Mon, 10 Jun 2024 16:52:03 -0700 Subject: [PATCH 1/2] [Impeller] disabling the color write mask seems to improve performance on iOS compared to just the blend options. --- impeller/entity/contents/content_context.cc | 1 + 1 file changed, 1 insertion(+) diff --git a/impeller/entity/contents/content_context.cc b/impeller/entity/contents/content_context.cc index dc8985bb5acc5..e250c9714e8ac 100644 --- a/impeller/entity/contents/content_context.cc +++ b/impeller/entity/contents/content_context.cc @@ -69,6 +69,7 @@ void ContentContextOptions::ApplyToPipelineDescriptor( color0.dst_color_blend_factor = BlendFactor::kOne; color0.src_alpha_blend_factor = BlendFactor::kZero; color0.src_color_blend_factor = BlendFactor::kZero; + color0.write_mask = ColorWriteMaskBits::kNone; break; case BlendMode::kSourceOver: color0.dst_alpha_blend_factor = BlendFactor::kOneMinusSourceAlpha; From 502c2bfdcdfb9654d1921205b4969e0e0e6a58cb Mon Sep 17 00:00:00 2001 From: jonahwilliams Date: Mon, 10 Jun 2024 16:53:38 -0700 Subject: [PATCH 2/2] ++ --- impeller/entity/contents/content_context.cc | 1 + 1 file changed, 1 insertion(+) diff --git a/impeller/entity/contents/content_context.cc b/impeller/entity/contents/content_context.cc index e250c9714e8ac..35d51c4795d54 100644 --- a/impeller/entity/contents/content_context.cc +++ b/impeller/entity/contents/content_context.cc @@ -40,6 +40,7 @@ void ContentContextOptions::ApplyToPipelineDescriptor( color0.format = color_attachment_pixel_format; color0.alpha_blend_op = BlendOperation::kAdd; color0.color_blend_op = BlendOperation::kAdd; + color0.write_mask = ColorWriteMaskBits::kAll; switch (pipeline_blend) { case BlendMode::kClear: