From 0919f5488e7ddf240679c3bb905a53f9d7bbf82b Mon Sep 17 00:00:00 2001 From: jonahwilliams Date: Tue, 11 Jun 2024 08:48:48 -0700 Subject: [PATCH 1/2] [engine] null check texture registry in OnPlatformViewMarkTextureFrameAvailable. --- shell/common/shell.cc | 3 +++ 1 file changed, 3 insertions(+) diff --git a/shell/common/shell.cc b/shell/common/shell.cc index 7b5d208534334..71f2cc917a7fe 100644 --- a/shell/common/shell.cc +++ b/shell/common/shell.cc @@ -1186,6 +1186,9 @@ void Shell::OnPlatformViewMarkTextureFrameAvailable(int64_t texture_id) { // Tell the rasterizer that one of its textures has a new frame available. task_runners_.GetRasterTaskRunner()->PostTask( [rasterizer = rasterizer_->GetWeakPtr(), texture_id]() { + if (rasterizer) { + return; + } auto registry = rasterizer->GetTextureRegistry(); if (!registry) { From 207fd8837e8be5f014781fa1077b81e3e5522ca4 Mon Sep 17 00:00:00 2001 From: Jonah Williams Date: Tue, 11 Jun 2024 09:09:44 -0700 Subject: [PATCH 2/2] Update shell.cc --- shell/common/shell.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/shell/common/shell.cc b/shell/common/shell.cc index 71f2cc917a7fe..5f6076b5a7f25 100644 --- a/shell/common/shell.cc +++ b/shell/common/shell.cc @@ -1186,7 +1186,7 @@ void Shell::OnPlatformViewMarkTextureFrameAvailable(int64_t texture_id) { // Tell the rasterizer that one of its textures has a new frame available. task_runners_.GetRasterTaskRunner()->PostTask( [rasterizer = rasterizer_->GetWeakPtr(), texture_id]() { - if (rasterizer) { + if (!rasterizer) { return; } auto registry = rasterizer->GetTextureRegistry();