From 29249878aaafb7452fcc0dd3bc760c2b7f7a7c79 Mon Sep 17 00:00:00 2001 From: Jenn Magder Date: Mon, 26 Aug 2024 10:14:32 -0700 Subject: [PATCH] Revert "Test running the macOS engine has no stray logging This reverts commit 5aed693f87b5a77bc7b3aa7e6e411f12f7deb921. --- .../darwin/macos/framework/Source/FlutterEngineTest.mm | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/shell/platform/darwin/macos/framework/Source/FlutterEngineTest.mm b/shell/platform/darwin/macos/framework/Source/FlutterEngineTest.mm index 7b7d4fb427f1a..b7d8eb231118e 100644 --- a/shell/platform/darwin/macos/framework/Source/FlutterEngineTest.mm +++ b/shell/platform/darwin/macos/framework/Source/FlutterEngineTest.mm @@ -210,7 +210,6 @@ @implementation MockableFlutterEngine // Replace stdout stream buffer with our own. StreamCapture stdout_capture(&std::cout); - StreamCapture stderr_capture(&std::cerr); // Launch the test entrypoint. FlutterEngine* engine = GetFlutterEngine(); @@ -220,12 +219,9 @@ @implementation MockableFlutterEngine latch.Wait(); stdout_capture.Stop(); - stderr_capture.Stop(); // Verify hello world was written to stdout. - // Check equality to ensure no unexpected stray logging. - EXPECT_EQ(stdout_capture.GetOutput(), "flutter: Hello logging\n"); - EXPECT_TRUE(stderr_capture.GetOutput().empty()); + EXPECT_TRUE(stdout_capture.GetOutput().find("Hello logging") != std::string::npos); } TEST_F(FlutterEngineTest, DISABLED_BackgroundIsBlack) {