From 4de1622d144162e5c4e22566fd0e75462037a10f Mon Sep 17 00:00:00 2001 From: Chris Bracken Date: Thu, 3 Oct 2024 10:18:31 -0700 Subject: [PATCH] iOS: Fix IOSSurfaceNoopTest Previously, we were passing nullptr to the IOSSurfaceNoop constructor: https://github.com/flutter/engine/blob/de1762dbc5cc3483631c5e511a3496998ec6cf65/shell/platform/darwin/ios/ios_surface_noop.mm#L23-L24 which calls the IOSSurface constructor: https://github.com/flutter/engine/blob/de1762dbc5cc3483631c5e511a3496998ec6cf65/shell/platform/darwin/ios/ios_surface.mm#L55-L58 Which calls `FML_DCHECK(ios_context_)`, which really doesn't like it when `ios_context_` is null. --- shell/platform/darwin/ios/ios_surface_noop_unittests.mm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/shell/platform/darwin/ios/ios_surface_noop_unittests.mm b/shell/platform/darwin/ios/ios_surface_noop_unittests.mm index 567026f144c8f..b85dbfedcc010 100644 --- a/shell/platform/darwin/ios/ios_surface_noop_unittests.mm +++ b/shell/platform/darwin/ios/ios_surface_noop_unittests.mm @@ -14,6 +14,7 @@ #import "flutter/lib/ui/window/platform_message_response.h" #import "flutter/shell/common/thread_host.h" #import "flutter/shell/platform/darwin/common/framework/Headers/FlutterMacros.h" +#import "flutter/shell/platform/darwin/ios/ios_context_noop.h" FLUTTER_ASSERT_ARC @@ -22,7 +23,8 @@ @interface IOSSurfaceNoopTest : XCTestCase @implementation IOSSurfaceNoopTest - (void)testCreateSurface { - flutter::IOSSurfaceNoop noop(nullptr); + auto context = std::make_shared(); + flutter::IOSSurfaceNoop noop(context); XCTAssertTrue(noop.IsValid()); XCTAssertTrue(!!noop.CreateGPUSurface());