From 9c5e7b6ec28437f68c8a204efa22a304b10afb55 Mon Sep 17 00:00:00 2001 From: Chris Bracken Date: Thu, 3 Oct 2024 11:48:28 -0700 Subject: [PATCH 1/2] DO NOT MERGE: Let's find out if NDEBUG is defined in ios_debug_sim builds --- shell/platform/darwin/ios/ios_surface_noop_unittests.mm | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/shell/platform/darwin/ios/ios_surface_noop_unittests.mm b/shell/platform/darwin/ios/ios_surface_noop_unittests.mm index 567026f144c8f..92cf5a6e6b10e 100644 --- a/shell/platform/darwin/ios/ios_surface_noop_unittests.mm +++ b/shell/platform/darwin/ios/ios_surface_noop_unittests.mm @@ -22,6 +22,12 @@ @interface IOSSurfaceNoopTest : XCTestCase @implementation IOSSurfaceNoopTest - (void)testCreateSurface { +#ifdef NDEBUG + NSLog(@"============================= NDEBUG is defined"); +#else + NSLog(@"============================= NDEBUG is NOT defined"); +#endif + flutter::IOSSurfaceNoop noop(nullptr); XCTAssertTrue(noop.IsValid()); From 2c5f239db13e37aa14e7c23f907aead5d1d97352 Mon Sep 17 00:00:00 2001 From: Chris Bracken Date: Thu, 3 Oct 2024 12:46:37 -0700 Subject: [PATCH 2/2] Hey why not check DEBUG too --- shell/platform/darwin/ios/ios_surface_noop_unittests.mm | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/shell/platform/darwin/ios/ios_surface_noop_unittests.mm b/shell/platform/darwin/ios/ios_surface_noop_unittests.mm index 92cf5a6e6b10e..c15274dea6a1d 100644 --- a/shell/platform/darwin/ios/ios_surface_noop_unittests.mm +++ b/shell/platform/darwin/ios/ios_surface_noop_unittests.mm @@ -27,6 +27,11 @@ - (void)testCreateSurface { #else NSLog(@"============================= NDEBUG is NOT defined"); #endif +#ifdef DEBUG + NSLog(@"============================= DEBUG is defined"); +#else + NSLog(@"============================= DEBUG is NOT defined"); +#endif flutter::IOSSurfaceNoop noop(nullptr);