From 5df81a6e2b925fdd04f3e2763a0b5cb628e684ba Mon Sep 17 00:00:00 2001 From: Jason Simmons Date: Mon, 13 Aug 2018 16:05:33 -0700 Subject: [PATCH] Do not log unwind errors during isolate shutdown --- runtime/dart_isolate.cc | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/runtime/dart_isolate.cc b/runtime/dart_isolate.cc index 71dfa136f45a5..e48c542c11d61 100644 --- a/runtime/dart_isolate.cc +++ b/runtime/dart_isolate.cc @@ -808,10 +808,12 @@ void DartIsolate::DartIsolateShutdownCallback( } tonic::DartApiScope api_scope; - FML_LOG(ERROR) << "Isolate " << tonic::StdStringFromDart(Dart_DebugName()) - << " exited with an error"; Dart_Handle sticky_error = Dart_GetStickyError(); - FML_CHECK(tonic::LogIfError(sticky_error)); + if (!Dart_IsFatalError(sticky_error)) { + FML_LOG(ERROR) << "Isolate " << tonic::StdStringFromDart(Dart_DebugName()) + << " exited with an error"; + FML_CHECK(tonic::LogIfError(sticky_error)); + } } // |Dart_IsolateCleanupCallback|