From b1f749f7f424d1d3c612a817b02ec92d858edb38 Mon Sep 17 00:00:00 2001 From: Dan Field Date: Tue, 23 Oct 2018 11:10:58 -0700 Subject: [PATCH 1/3] Update contributing.md for xcode_backend refactor notes --- CONTRIBUTING.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 6fe6a92aafd73..3424289d63cc2 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -171,6 +171,7 @@ Once the artifacts are built, you can start using them in your application by fo * `../../bin/flutter run --local-engine-src-path /path/to/engine/src --local-engine=ios_debug_unopt` or `--local-engine=ios_debug_sim_unopt` for simulator * If you are debugging crashes in the engine, you can connect the `LLDB` debugger from `Xcode` by opening `ios/Runner.xcworkspace` and starting the application by clicking the Run button (CMD + R). * To debug non crashing code, open Xcode with `ios/Runner.xcworkspace`, expand Flutter->Runner->Supporting Files->main.m in the Runner project. Put a breakpoint in main() then set your desired breakpoint in the engine in [lldb](https://lldb.llvm.org/tutorial.html) via `breakpoint set -...`. + * Note that this will set a `$LOCAL_ENGINE` variable in your `Generated.xcconfig` file for the Flutter application. This variable will be set until you run `flutter run` again with either a different `--local-engine` option, or with none at all (which will unset it). This is important to note if you plan to re-run your Flutter `Runner.xcodeproj` directly from Xcode. In that case, you should also consider updating the custom run script that calls `$FLUTTER_ROOT/packages/flutter_tools/bin/xcode_backend.sh` to also call that script with the `embed` parameter. ### Desktop (Mac and Linux), for tests From 870ee009f13ad4d3b6a587275ee29bba1a064fd0 Mon Sep 17 00:00:00 2001 From: Dan Field Date: Wed, 24 Oct 2018 14:43:39 -0700 Subject: [PATCH 2/3] clarify --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 3424289d63cc2..0aa42151084fa 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -171,7 +171,7 @@ Once the artifacts are built, you can start using them in your application by fo * `../../bin/flutter run --local-engine-src-path /path/to/engine/src --local-engine=ios_debug_unopt` or `--local-engine=ios_debug_sim_unopt` for simulator * If you are debugging crashes in the engine, you can connect the `LLDB` debugger from `Xcode` by opening `ios/Runner.xcworkspace` and starting the application by clicking the Run button (CMD + R). * To debug non crashing code, open Xcode with `ios/Runner.xcworkspace`, expand Flutter->Runner->Supporting Files->main.m in the Runner project. Put a breakpoint in main() then set your desired breakpoint in the engine in [lldb](https://lldb.llvm.org/tutorial.html) via `breakpoint set -...`. - * Note that this will set a `$LOCAL_ENGINE` variable in your `Generated.xcconfig` file for the Flutter application. This variable will be set until you run `flutter run` again with either a different `--local-engine` option, or with none at all (which will unset it). This is important to note if you plan to re-run your Flutter `Runner.xcodeproj` directly from Xcode. In that case, you should also consider updating the custom run script that calls `$FLUTTER_ROOT/packages/flutter_tools/bin/xcode_backend.sh` to also call that script with the `embed` parameter. + * Note that this will set a `$LOCAL_ENGINE` variable in your `Generated.xcconfig` file for the Flutter application. This variable will be set until you run `flutter run` again with either a different `--local-engine` option, or with none at all (which will unset it). This is important to note if you plan to re-run your Flutter `Runner.xcodeproj` directly from Xcode. In that case, you should also consider updating the custom run script in your Xcode build phases that calls `"$FLUTTER_ROOT/packages/flutter_tools/bin/xcode_backend.sh" build` to also call `"$FLUTTER_ROOT/packages/flutter_tools/bin/xcode_backend.sh" embed`. ### Desktop (Mac and Linux), for tests From b83bd8029c4e07b0fdcd045381de3da93c37324b Mon Sep 17 00:00:00 2001 From: Dan Field Date: Wed, 24 Oct 2018 15:55:58 -0700 Subject: [PATCH 3/3] remove unnecessary line --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 0aa42151084fa..5b8c2741257e2 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -171,7 +171,7 @@ Once the artifacts are built, you can start using them in your application by fo * `../../bin/flutter run --local-engine-src-path /path/to/engine/src --local-engine=ios_debug_unopt` or `--local-engine=ios_debug_sim_unopt` for simulator * If you are debugging crashes in the engine, you can connect the `LLDB` debugger from `Xcode` by opening `ios/Runner.xcworkspace` and starting the application by clicking the Run button (CMD + R). * To debug non crashing code, open Xcode with `ios/Runner.xcworkspace`, expand Flutter->Runner->Supporting Files->main.m in the Runner project. Put a breakpoint in main() then set your desired breakpoint in the engine in [lldb](https://lldb.llvm.org/tutorial.html) via `breakpoint set -...`. - * Note that this will set a `$LOCAL_ENGINE` variable in your `Generated.xcconfig` file for the Flutter application. This variable will be set until you run `flutter run` again with either a different `--local-engine` option, or with none at all (which will unset it). This is important to note if you plan to re-run your Flutter `Runner.xcodeproj` directly from Xcode. In that case, you should also consider updating the custom run script in your Xcode build phases that calls `"$FLUTTER_ROOT/packages/flutter_tools/bin/xcode_backend.sh" build` to also call `"$FLUTTER_ROOT/packages/flutter_tools/bin/xcode_backend.sh" embed`. + * Note that this will set a `$LOCAL_ENGINE` variable in your `Generated.xcconfig` file for the Flutter application. This variable will be set until you run `flutter run` again with either a different `--local-engine` option, or with none at all (which will unset it). This is important to note if you plan to re-run your Flutter `Runner.xcodeproj` directly from Xcode. ### Desktop (Mac and Linux), for tests