From b2654c31c507fc96a84b84ba0a013e64a2bae56f Mon Sep 17 00:00:00 2001 From: Dan Field Date: Thu, 7 Mar 2019 14:20:20 -0800 Subject: [PATCH 1/2] Mark const extern --- .../darwin/ios/framework/Headers/FlutterViewController.h | 2 +- .../darwin/ios/framework/Source/FlutterViewController.mm | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/shell/platform/darwin/ios/framework/Headers/FlutterViewController.h b/shell/platform/darwin/ios/framework/Headers/FlutterViewController.h index 1ac7d61c5e614..5881b3c1aeff6 100644 --- a/shell/platform/darwin/ios/framework/Headers/FlutterViewController.h +++ b/shell/platform/darwin/ios/framework/Headers/FlutterViewController.h @@ -23,7 +23,7 @@ * The object passed as the sender is the `FlutterViewController` associated * with the update. */ -const NSNotificationName FlutterSemanticsUpdateNotification = @"FlutterSemanticsUpdate"; +extern NSNotificationName const FlutterSemanticsUpdateNotification; /** * A `UIViewController` implementation for Flutter views. diff --git a/shell/platform/darwin/ios/framework/Source/FlutterViewController.mm b/shell/platform/darwin/ios/framework/Source/FlutterViewController.mm index 2e4a265d17f0e..076e3bec3402b 100644 --- a/shell/platform/darwin/ios/framework/Source/FlutterViewController.mm +++ b/shell/platform/darwin/ios/framework/Source/FlutterViewController.mm @@ -22,6 +22,8 @@ #include "flutter/shell/platform/darwin/ios/framework/Source/platform_message_response_darwin.h" #include "flutter/shell/platform/darwin/ios/platform_view_ios.h" +NSNotificationName const FlutterSemanticsUpdateNotification = @"FlutterSemanticsUpdate"; + @implementation FlutterViewController { std::unique_ptr> _weakFactory; fml::scoped_nsobject _engine; From 132d2037d841e259891793131bf9fb4fc0bade17 Mon Sep 17 00:00:00 2001 From: Dan Field Date: Thu, 7 Mar 2019 14:57:41 -0800 Subject: [PATCH 2/2] fix build --- .cirrus.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.cirrus.yml b/.cirrus.yml index d55ef85f89ad5..4ea101ac93b66 100644 --- a/.cirrus.yml +++ b/.cirrus.yml @@ -11,7 +11,7 @@ gke_container: task: env: CIRRUS_WORKING_DIR: "/tmp/github_repo" - + DEPOT_TOOLS_UPDATE: 0 replace_engine_script: | cd $ENGINE_PATH/src rm -r flutter @@ -88,7 +88,7 @@ format_and_dart_test_task: env: CIRRUS_WORKING_DIR: "/tmp/github_repo" - + DEPOT_TOOLS_UPDATE: 0 replace_engine_script: | cd $ENGINE_PATH/src rm -r flutter