From a96c235150704df76b0e3cb9e9f02cae1610774d Mon Sep 17 00:00:00 2001 From: Aaron Clarke Date: Wed, 12 Jun 2019 13:04:26 -0700 Subject: [PATCH 1/5] Added class docstrings for classes inside of shell/common. --- shell/common/animator.h | 4 ++++ shell/common/engine.h | 1 + shell/common/isolate_configuration.h | 1 + shell/common/persistent_cache.h | 1 + shell/common/pipeline.h | 1 + shell/common/platform_view.h | 2 ++ shell/common/rasterizer.h | 1 + shell/common/run_configuration.h | 3 +++ shell/common/shell.h | 2 ++ shell/common/surface.h | 1 + shell/common/thread_host.h | 1 + shell/common/vsync_waiter.h | 2 ++ shell/common/vsync_waiter_fallback.h | 1 + 13 files changed, 21 insertions(+) diff --git a/shell/common/animator.h b/shell/common/animator.h index 32c02f789fe0a..083c832d6f9d9 100644 --- a/shell/common/animator.h +++ b/shell/common/animator.h @@ -22,6 +22,10 @@ namespace testing { class ShellTest; } +/// Executor of animations on a |LayerTree|. +/// +/// This typically happens after the Layout and Paint passes in the Dart code +/// and before the LayerTree is Rasterized. class Animator final { public: class Delegate { diff --git a/shell/common/engine.h b/shell/common/engine.h index 1a84f9f4216f3..9917da4f0aa8d 100644 --- a/shell/common/engine.h +++ b/shell/common/engine.h @@ -29,6 +29,7 @@ namespace flutter { +/// Runner of the Dart code. class Engine final : public RuntimeDelegate { public: // Used by Engine::Run diff --git a/shell/common/isolate_configuration.h b/shell/common/isolate_configuration.h index a6db9edb69f43..88833df7faf23 100644 --- a/shell/common/isolate_configuration.h +++ b/shell/common/isolate_configuration.h @@ -19,6 +19,7 @@ namespace flutter { +/// Abstract Base Class that will configure a |DartIsolate|. class IsolateConfiguration { public: static std::unique_ptr InferFromSettings( diff --git a/shell/common/persistent_cache.h b/shell/common/persistent_cache.h index f26e819e81aa7..ce2a1044d5fed 100644 --- a/shell/common/persistent_cache.h +++ b/shell/common/persistent_cache.h @@ -17,6 +17,7 @@ namespace flutter { +/// A cache of shaders that gets stored to disk. class PersistentCache : public GrContextOptions::PersistentCache { public: // Mutable static switch that can be set before GetCacheForProcess. If true, diff --git a/shell/common/pipeline.h b/shell/common/pipeline.h index cf959eaa20012..66f1d4da49a5f 100644 --- a/shell/common/pipeline.h +++ b/shell/common/pipeline.h @@ -24,6 +24,7 @@ enum class PipelineConsumeResult { size_t GetNextPipelineTraceID(); +/// A thread-safe queue of resources. template class Pipeline : public fml::RefCountedThreadSafe> { public: diff --git a/shell/common/platform_view.h b/shell/common/platform_view.h index c8e44836afec9..7965975249a50 100644 --- a/shell/common/platform_view.h +++ b/shell/common/platform_view.h @@ -25,6 +25,8 @@ namespace flutter { class Shell; +/// Abstract Base Class that represents the platform specific view we will be +/// rendering to. class PlatformView { public: class Delegate { diff --git a/shell/common/rasterizer.h b/shell/common/rasterizer.h index 7d525816da73a..b9fc92d11834b 100644 --- a/shell/common/rasterizer.h +++ b/shell/common/rasterizer.h @@ -20,6 +20,7 @@ namespace flutter { +/// Takes |LayerTree|s and draws its contents. class Rasterizer final : public SnapshotDelegate { public: class Delegate { diff --git a/shell/common/run_configuration.h b/shell/common/run_configuration.h index a8b3a8b6e72f1..d5dfd29e0b92e 100644 --- a/shell/common/run_configuration.h +++ b/shell/common/run_configuration.h @@ -18,6 +18,9 @@ namespace flutter { +/// Configuration pertaining to how we will execute the Dart code. +/// +/// For example: what will be the first function we execute (entrypoint). class RunConfiguration { public: static RunConfiguration InferFromSettings( diff --git a/shell/common/shell.h b/shell/common/shell.h index a226761ff2ef1..a05ff47e897f8 100644 --- a/shell/common/shell.h +++ b/shell/common/shell.h @@ -34,6 +34,8 @@ namespace flutter { +/// Wraps up all the different components of Flutter engine and coordinates them +/// through a series of delegates. class Shell final : public PlatformView::Delegate, public Animator::Delegate, public Engine::Delegate, diff --git a/shell/common/surface.h b/shell/common/surface.h index 06bebed09c51f..7bbc16e24c690 100644 --- a/shell/common/surface.h +++ b/shell/common/surface.h @@ -41,6 +41,7 @@ class SurfaceFrame { FML_DISALLOW_COPY_AND_ASSIGN(SurfaceFrame); }; +/// Abstract Base Class that represents where we will be rendering content. class Surface { public: Surface(); diff --git a/shell/common/thread_host.h b/shell/common/thread_host.h index 93f42a90861e8..b5e14e6fa6bf8 100644 --- a/shell/common/thread_host.h +++ b/shell/common/thread_host.h @@ -12,6 +12,7 @@ namespace flutter { +/// The collection of all the threads used by the engine. struct ThreadHost { enum Type { Platform = 1 << 0, diff --git a/shell/common/vsync_waiter.h b/shell/common/vsync_waiter.h index 3d2cd7aca8a0c..5e80dd4c09c6b 100644 --- a/shell/common/vsync_waiter.h +++ b/shell/common/vsync_waiter.h @@ -15,6 +15,8 @@ namespace flutter { +/// Abstract Base Class that represents a platform specific mechanism for +/// getting callbacks when a vsync event happens. class VsyncWaiter : public std::enable_shared_from_this { public: using Callback = std::function Date: Wed, 12 Jun 2019 13:04:26 -0700 Subject: [PATCH 2/5] Added class docstrings for classes inside of shell/common. --- shell/common/animator.h | 4 ++++ shell/common/engine.h | 1 + shell/common/isolate_configuration.h | 1 + shell/common/persistent_cache.h | 1 + shell/common/pipeline.h | 1 + shell/common/platform_view.h | 2 ++ shell/common/rasterizer.h | 1 + shell/common/run_configuration.h | 3 +++ shell/common/shell.h | 2 ++ shell/common/surface.h | 1 + shell/common/thread_host.h | 1 + shell/common/vsync_waiter.h | 2 ++ shell/common/vsync_waiter_fallback.h | 1 + 13 files changed, 21 insertions(+) diff --git a/shell/common/animator.h b/shell/common/animator.h index 32c02f789fe0a..083c832d6f9d9 100644 --- a/shell/common/animator.h +++ b/shell/common/animator.h @@ -22,6 +22,10 @@ namespace testing { class ShellTest; } +/// Executor of animations on a |LayerTree|. +/// +/// This typically happens after the Layout and Paint passes in the Dart code +/// and before the LayerTree is Rasterized. class Animator final { public: class Delegate { diff --git a/shell/common/engine.h b/shell/common/engine.h index 1a84f9f4216f3..9917da4f0aa8d 100644 --- a/shell/common/engine.h +++ b/shell/common/engine.h @@ -29,6 +29,7 @@ namespace flutter { +/// Runner of the Dart code. class Engine final : public RuntimeDelegate { public: // Used by Engine::Run diff --git a/shell/common/isolate_configuration.h b/shell/common/isolate_configuration.h index a6db9edb69f43..88833df7faf23 100644 --- a/shell/common/isolate_configuration.h +++ b/shell/common/isolate_configuration.h @@ -19,6 +19,7 @@ namespace flutter { +/// Abstract Base Class that will configure a |DartIsolate|. class IsolateConfiguration { public: static std::unique_ptr InferFromSettings( diff --git a/shell/common/persistent_cache.h b/shell/common/persistent_cache.h index f26e819e81aa7..ce2a1044d5fed 100644 --- a/shell/common/persistent_cache.h +++ b/shell/common/persistent_cache.h @@ -17,6 +17,7 @@ namespace flutter { +/// A cache of shaders that gets stored to disk. class PersistentCache : public GrContextOptions::PersistentCache { public: // Mutable static switch that can be set before GetCacheForProcess. If true, diff --git a/shell/common/pipeline.h b/shell/common/pipeline.h index cf959eaa20012..66f1d4da49a5f 100644 --- a/shell/common/pipeline.h +++ b/shell/common/pipeline.h @@ -24,6 +24,7 @@ enum class PipelineConsumeResult { size_t GetNextPipelineTraceID(); +/// A thread-safe queue of resources. template class Pipeline : public fml::RefCountedThreadSafe> { public: diff --git a/shell/common/platform_view.h b/shell/common/platform_view.h index c8e44836afec9..7965975249a50 100644 --- a/shell/common/platform_view.h +++ b/shell/common/platform_view.h @@ -25,6 +25,8 @@ namespace flutter { class Shell; +/// Abstract Base Class that represents the platform specific view we will be +/// rendering to. class PlatformView { public: class Delegate { diff --git a/shell/common/rasterizer.h b/shell/common/rasterizer.h index 7d525816da73a..b9fc92d11834b 100644 --- a/shell/common/rasterizer.h +++ b/shell/common/rasterizer.h @@ -20,6 +20,7 @@ namespace flutter { +/// Takes |LayerTree|s and draws its contents. class Rasterizer final : public SnapshotDelegate { public: class Delegate { diff --git a/shell/common/run_configuration.h b/shell/common/run_configuration.h index a8b3a8b6e72f1..d5dfd29e0b92e 100644 --- a/shell/common/run_configuration.h +++ b/shell/common/run_configuration.h @@ -18,6 +18,9 @@ namespace flutter { +/// Configuration pertaining to how we will execute the Dart code. +/// +/// For example: what will be the first function we execute (entrypoint). class RunConfiguration { public: static RunConfiguration InferFromSettings( diff --git a/shell/common/shell.h b/shell/common/shell.h index a226761ff2ef1..a05ff47e897f8 100644 --- a/shell/common/shell.h +++ b/shell/common/shell.h @@ -34,6 +34,8 @@ namespace flutter { +/// Wraps up all the different components of Flutter engine and coordinates them +/// through a series of delegates. class Shell final : public PlatformView::Delegate, public Animator::Delegate, public Engine::Delegate, diff --git a/shell/common/surface.h b/shell/common/surface.h index 06bebed09c51f..7bbc16e24c690 100644 --- a/shell/common/surface.h +++ b/shell/common/surface.h @@ -41,6 +41,7 @@ class SurfaceFrame { FML_DISALLOW_COPY_AND_ASSIGN(SurfaceFrame); }; +/// Abstract Base Class that represents where we will be rendering content. class Surface { public: Surface(); diff --git a/shell/common/thread_host.h b/shell/common/thread_host.h index 93f42a90861e8..b5e14e6fa6bf8 100644 --- a/shell/common/thread_host.h +++ b/shell/common/thread_host.h @@ -12,6 +12,7 @@ namespace flutter { +/// The collection of all the threads used by the engine. struct ThreadHost { enum Type { Platform = 1 << 0, diff --git a/shell/common/vsync_waiter.h b/shell/common/vsync_waiter.h index 3d2cd7aca8a0c..5e80dd4c09c6b 100644 --- a/shell/common/vsync_waiter.h +++ b/shell/common/vsync_waiter.h @@ -15,6 +15,8 @@ namespace flutter { +/// Abstract Base Class that represents a platform specific mechanism for +/// getting callbacks when a vsync event happens. class VsyncWaiter : public std::enable_shared_from_this { public: using Callback = std::function Date: Wed, 12 Jun 2019 13:04:26 -0700 Subject: [PATCH 3/5] Added class docstrings for classes inside of shell/common. revision 2 --- shell/common/animator.h | 6 +++--- shell/common/engine.h | 4 +++- shell/common/pipeline.h | 3 ++- shell/common/vsync_waiter_fallback.h | 2 +- 4 files changed, 9 insertions(+), 6 deletions(-) diff --git a/shell/common/animator.h b/shell/common/animator.h index 083c832d6f9d9..9f84468c01b78 100644 --- a/shell/common/animator.h +++ b/shell/common/animator.h @@ -22,10 +22,10 @@ namespace testing { class ShellTest; } -/// Executor of animations on a |LayerTree|. +/// Executor of animations. /// -/// This typically happens after the Layout and Paint passes in the Dart code -/// and before the LayerTree is Rasterized. +/// In conjunction with the |VsyncWaiter| it allows callers (typically Dart +/// code) to schedule work that ends up generating a |LayerTree|. class Animator final { public: class Delegate { diff --git a/shell/common/engine.h b/shell/common/engine.h index 9917da4f0aa8d..293d78c1a7178 100644 --- a/shell/common/engine.h +++ b/shell/common/engine.h @@ -29,7 +29,9 @@ namespace flutter { -/// Runner of the Dart code. +/// Manager of the root Dart isolate and the relay of platform messages. +/// +/// Also setups up dart::ui bindings and handles restarts. class Engine final : public RuntimeDelegate { public: // Used by Engine::Run diff --git a/shell/common/pipeline.h b/shell/common/pipeline.h index 66f1d4da49a5f..247368b71718d 100644 --- a/shell/common/pipeline.h +++ b/shell/common/pipeline.h @@ -24,7 +24,8 @@ enum class PipelineConsumeResult { size_t GetNextPipelineTraceID(); -/// A thread-safe queue of resources. +/// A thread-safe queue of resources for a single consumer and a single +/// producer. template class Pipeline : public fml::RefCountedThreadSafe> { public: diff --git a/shell/common/vsync_waiter_fallback.h b/shell/common/vsync_waiter_fallback.h index cecafdf82f7d2..5226dda019504 100644 --- a/shell/common/vsync_waiter_fallback.h +++ b/shell/common/vsync_waiter_fallback.h @@ -12,7 +12,7 @@ namespace flutter { -/// A fake |VsyncWaiter| that will fire at 60 fps. +/// A |VsyncWaiter| that will fire at 60 fps irrespective of the vsync. class VsyncWaiterFallback final : public VsyncWaiter { public: VsyncWaiterFallback(TaskRunners task_runners); From 3a2ea32c9241515b8a44813dfbd784623943efcc Mon Sep 17 00:00:00 2001 From: Aaron Clarke Date: Wed, 12 Jun 2019 16:31:13 -0700 Subject: [PATCH 4/5] Removed file I accidently commited. --- .../resources/performance_overlay_gold_new.png | Bin 18074 -> 0 bytes 1 file changed, 0 insertions(+), 0 deletions(-) delete mode 100644 testing/resources/performance_overlay_gold_new.png diff --git a/testing/resources/performance_overlay_gold_new.png b/testing/resources/performance_overlay_gold_new.png deleted file mode 100644 index f0924ba96dee49b603c8842c74fcd18a4f0dbcbf..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 18074 zcmeI42UJsAx9>T6Y$#wrL8NJDdZ^MnmLMPkDk>eMO9_bdP=X>&6b>N0L_k2g^b(4Q z7$UvK03p(AKxzmrZ^iF^-+lMq=e_s6cgJ{ToD3br&CcFy&o$RvbI#vChTqXqXP`e% zPe(_`ps4}7M@M&fj`sKXQE)^%YhVie_}%Tg=KbT~<#*gVjE?RCohIzseecvIg8h^G zl)bn4#)&cNC@6Js@L? ze0d08-xWKic4`WIizS|DFi(R^Wc|JYrI$Z~9CnTgWZ%a({@_bT>5x7iX z_sfuwkfppWU5*}xmTl~4+~KPylDDGtmStbD&E_$KQ@%^y=&x|mt|UsC2micrAQsZ| z8|~d4y5G2d9yxOQuLJ*A+ar+T%ogaYZj*gqyOR3tioBe8rQeXN2pDtVE|W5Fdhogw z7|2Nb8F=XUe|W&VV_0dt)Zpjoc|Ae@>T_39mXGlB^ApzZw(S>Z@wO@t9*m9#A{!lQ zP01~GHRc^#Mgy`^*4mXwS53`s(!ddLokvd@7#Q$+B$Ov3!py9}C4avoEj?-1f^ld6 z2m3NxziEWM^kcoF8#_BY#IA*H+MS&Z=r9s0lI zz&b&c&Mmj>UVhFnaw(BBwZ!PYv?)j4ox`{jV4T}dna6(RNF4}9g?0O%AumxGUdJYv zhC10f^LuUWZ&ar-F=$_J^hA26e2y>mcE^@m$ChLVMt&wU&2~|zdflX^pClJ6lSq<3 z)ZFwfXSk{6-8(xO49%8L3jQhbjs!K@b_R2lUw$Nt=&>8oQe_kJ>IN6WXdFH}Y+tqP zuGk%{NQjiQ4>Ck{O&VeEqZbz!k%|SAGy~TJ=V%kuyEy;Jk%5~&)71=){yA&QsvH0F zlkokD5w=QEQAGT z9BsgKiRXU3;N<6Oa>b*5Muh$Uorv&{ATonCrCa8y;~sqZQst?goveJZN!}9AxweQ= zQu348;OiIH^Yn7#t12pl-xn4tnVXo5`c^w00;613b7Sq%(?b_Bscc8e^4omOw09NZ zu5RVv;Nd*uZT^ zYm&wqe7j#MW8y``rc*j0{l|Fx$~}q~8ud(y&Dw*Q8cEt(i=_h00`m(-XX-uSEmx7$ z=RdY_tY-#t&ae)>t0OcFHSJ~R=N7@$9%WjEv{>xRHc_-6=xARv=@12eL7_9_R5i-RuDK0J!0~_knPm=YaOec7$W!-I;ZCri5kAXAC3bIjXXhy+r`(Tk-@kt^g^yI3zQj!C7zo<}3tpb= zwyNIkv~`0~EGPncCcfL_32bwSfdRZBb6BfWczwNszO!@CdK7XmVKF*PGTo0<=h3u2 zGd);qdBxH4(FIj0si|-s&ryAI|IOaW$jDD`-n?n<=;%lv8XAhJCI;+cgHN(GzKMyE zD6#nFz$N3;@Vcu&Uv@J*%-T*C@1g9FUs5vH_p}L?geh zj0=_2mt|#VXAd~ZsF#(MDU_9$ADb=cD%}fcDr#tGn0t1NTP|hPbG|RT9z4)xF)>y0 zXBOR5G=~Q*T9G5DKWhj7ZTdCB^zxWKIW-Yt*qBiYiFe4gq_yp0GmC>r|i z)~)O%NAW@;n*-DZbeMyg1CCIh_CK0JQj6HU0-A}&=@-9JwD&1`A0zXE|o z@LS)~UHP!JaVCVJ#rhS}#mFf10nGY|xR=z%j-Sfzj~^fS1qCsvQ5kXZ@5e)1W=cn3 zH$Ua$Ij>Y!#qZ`9pynVD!^XYG?${WXBp)AruFg)TQ{iD#v&f~6_5!!fE!HEt>3f!; z7LQ{C(x1o`dU<+^0@E(-%>d_&4{HOKEw0~PMo00;Kb>-mQa#uf8NbAzP2^-$WJ$Kw zxOp>$)L(T?%0c({p!w49h07w!X}0H*2XLxWfCHO^FbyQq?3*)rG2>6gbfuQ%Q~dF)xc)9LSj^3!U~bo_p7(tB121WhQ32zzmTxtHgG zaQvTGFtJAtv0sUf_EnZFA7l-eV^%@QPPj8BX5ICLp05-XP&D_U>~crg7@&%a*Jr!g zDl019%uG#H_>mmVeY>seHYKBEW4E*tZ(H6PH8S%uOaB%U%J1=flAHEq$vNyys(Vk0 z+S8iLIBgR6NO>99YB8G{I;^ZT(YRJuu#P3)y&MyZAf%xW@ck4hI`i^ z?%?qCD;CS%@%1Zx*sE9h_Rh{*!p2pFdbmyFm&^0>n)3?_w?sgFP&Gng87l!^^ReO4 z&~K*wr(A0hML|JhPb5+!!uXi$To3lryJpkT-xk*?OL=*D8R287=;$j;?h5|RkDg@S zeqwy|=uytyEz)jG%lNtT+}xfI?!R(cS@?tTdjunxDRi(`VpP@$(*>Zcoq`^riRp^-WWyQo5TgWm0&FlrFCWy{Qtz zg4|qj_o+6V@!@B$ddGgiKDqZdL7_qqIk&>X1_qWET+!&FXIF2!m)*hR@ktKnLaLsO ze_F)C3mz6Z_>&1<*}1tG$%9Q9y+5xc)jHEwYy`Jp|Gi>~=E4w(yUG-AZ1@`{QUoSpoBB4%DFybf+Auyt@@o#E{n>6+ymGHR z*fc~USRdq8R*P}1Avn@l8U*G)hqG|NV4f>u{)Ls5(uBp$om~11Nq7^|nA&7Bd5lM6 zx;Y36UAwCm%sJLz{K*p?7WNH=JaDOYAqIF4=0C{l*IZawcxY>D>&d6?SiiGS5Vc7r z`>Mfcu`?0x6zR8~LiF<>Hu{^F83<=QmU6&JbzTw@+MQSD@vr#ty*Ws6aZ;wFnU?G@ywbUpq)5wLdrC{=^ok%i5)O6M+c{4JFu?`}AcH zs)f$b%L@q!F`<-qDUo1C*MUjoGb$3ek~oF&y(?=!K|pyCMc%y-bkr-q1ulR6*XP*-dkN^D>0|u?1G`P zOG>)=p%b2Hmt<72y%F>bz4rOFrLDIC-v1=+4%4@6h;0GB^@U51Jj;&xK_&CDYbn2>G_JR|qbE2iN*1y0gN~&6 z%bcveuRIpVIv|>laV4taV5cr8t=9Mqb1%PqDf@KNRV%X&(f#7LfWk-ObF2`b`Rs)B z-OUo@{?dB4DwW){Ggy+J<4bfW*_{lY+NgpIzDaV#6&Gnb?|x!yeDe0)yQ#7;jRy|~pOpk`7P#<{K}xV2!>=Xk zOl;hL1dZ+iPWVBqzv6ScvhNm%^pj0&kjW`*Y|59R)V;>#;mSqR(3UF$V`FCSlV4t| zamYBy89jL5@e%BsqUMeD3X~oH-7S9=;3v33L$|v8{Dr_)%M)n|9t-0K2LTv&5-pd0 z|9D7w&U5!qQHj3(pT{HN^pvNQ08!0YDweHf(!)GL_`e{i75EF zkcVbwX38T*UxY+Oi%05x+z4JxLcxrfJ4g`q@kK>K`>$Uw`az-g_NGIv5xREXN+MOy zo{ef~cNQ-YYym=J49`^@ie+%{&w!HZ=2B-uN-efYH*Lq#7n;EVIV6^^=7*xWPV|(B5E+ksxGX$iquQxW% z1T&u?JVE;wT1C;4t5@EmF(BV!J;Tm^kXCp@kDO0iPnW_sAFO>PO^Ev7Cmn( z(OQu=EYImFpaLgEhw+X-+3o~ucHhGzE#qMV|d@ zWb4ZoLp3$&JUF~P2*g2Tz-StkTvvDNkhFBv=F6~Dxz*_^b)J2TUTd5c zzRU__B;8M!N5{J6L%xSzzgTW@P5=@;F)<+o_C~JRZWQuEWo6~NijDg#)+k2-QgsgX zU8?sK#9m1FO-DL61mb%1&;;Bi;rWd1iTdq{=H=z(j;U3hG=<79z-3}1}QPIXSkHw*OD3nAZ8Gb zsimc58Eo5iX^LJ$eowjEd$ZK5K>{u|R%(T5%^Rkb_IG*<4y;Zx+Ramz9!|F#onfU4%NdwD4Afib7Ax z`ASHLM3z>jsqoXr0*o+=7F0CL%uf{v~@7!7B=4p&+9!-3d zS%SjI5~YguwAnte@hUSkH+Kl#g*{4_N_KIH?v>) z71z($q5QXQK%%?-m)&s4jVvC2c&4v);rwv7vfSFxhfaa5M|ZyF7i4>Oo~JZX*O9k$ zj8lZ^kCLz+3=^w0d0AOj;}fkBV!HZnF@p|VTz9R?@e^hxUO&E-S~=FC(d(GV?XXr$ ztKm_p9bOb>a@BurWv(HCQ<<4QxKP%4w2c)~8?cXZNq7P5S(DwYN8bNB=YOD_)(tMA0Da40IMaO#9(EQekUA{Hks z*xA`{K%qBo+>m9kqfWUxwoIBM(Oqf2`HKsK#m^=t-10yXU@|=&T1HPVS{uo|Z&NfSw>N48A^G?Y5UxwVs=?csKTE;{Lu#btNZ{b&@Ryon~~NgJ;9Wwvlw{(tB-9 zZBkWbWzmm_unudvT?5CVJr(2rQ{ZSBX_Ru^qRcb5oLJ{Jdonmz$G?;?+s@6Aa)KX2`!omWB;X&5dWMo)SNJC)H>x4qNqjGr_ z7154Mjja)ELez6N!L&Vsx|O}$?YVPPN~EYgK6%)N3w>vl6n2wzqNRrcBpey`A$*5@ z5Qvmcr^v*;gF?kMxzeR20kp<-M+d}{j!aj57y1?oB|)#OEIBnOs5Yabg3(v4)v=Z* zV0)8eGU~y-r!tj=OF@NN300dzIQ`Lq_Pj-2<#LeEMr$O#e)WnYYuyH373eIZe*4+g z9g%g)`r6u2H5f>RSi{=XX(4$NA7b%%etzC<%|Md20lCkwzG_dX-WnWOTF%SE6UzN} zyXpJ-M@Y7A-_AtfnOj?D`wl(pXtORr>)HvB_Usu>y?U_*`{Xn*q#{wLPy^~JonkYU z6rw9rDmMxhOmprbG(47Lb{*Xa($VRX zPOzA}i9`lmI$t?}^RNq$VxN`qij z<9?OW&eq6U7SF+llIm(%*>k6iM9u2A<*P>sD9$76_NKK@`MbqW_4j3KiSe;{qY;}6 z@A~O%Et{VoAq)-m6aVn)EN?!^=|(Gmu7GAOX^x&s>BMykxuIN{gUo;%`( zm`*XyydW%dFHW@D^{K%|oyoZi<8WHP0)@mkSYdQoWn@dX@T41vYt60qA<>{8Fcxj+ z`BBj>Yyi<_qp`o(gKl=wN5Fg%6bK?+#ysM8ABAbK5&uYRlFd*&%uQc1*6iyL)(uc!M&DrvmR34eEhV7)-`xOi6GZ z4(hGPpr+o>2p#LF^`nfdKp?qpJy1&t%PYp8rWY#Z(t_fLhx6^(WK%laNlHqo3iDwv zu(ZG$dc8Oi)4x;*x<=L6HgRHNC8GSQ)Uw@yye505;L*~~6mx8o_i8j~nw0hakTDfG zeAp*T^{9tu{O@aP3nsL_%c+@$hTx3H0}wJu?SDRrhX`XN&lQP>PXqQ0K<)2ucWEjz zO?lTnp{-4ty1$a<7<-M@7eRudt}Rgax~YEds}rr-vt4P%LTfl*YteV)O-(J=(!H$$ z^EmiQqfn+j^YP#BNo#9u`>Cj3IIS^K<2o5y?Yn2w9$(3$h318Y_(BYu8IiTml&lbX5>k(ZZ zeqUd;w|}VW)5?==VNmC;o?%02;WleLS0{Ltt@N*<#=g1n&px4ggzbGZ%Dn5FS?uhF z0)_R%Vx=X+4{v2W9$gUQlPJ3Ya#$Cel-pNGpMui}t2M3f^Lz?r!KO{CJ`9C3QiiXb zyB+mFe`Wp*#IS0~z}AP7AzUDBT}PXk#>VHp>D{!jK0F-H;M2fxx!_^LY$bj#J|{;y z2&?Yr)1cioIx3XqmXGq8Ng|ty;y!}*%ut%Lucw|8H;z`E`6{JfKGfAQa^ZAa7%ggm zj-fqpWqiRyt~SQtdzQ0Z%J|FBdqxNe)6dpY(nXEgf}2Bm$Ewpo`sSzT5fR3zdJtE2 z^@8NYri=ov*k4FimHM)v)RlDA%WL&Rzx?AWgAk91=^1+#$r819pk#U*rlF;U*H--k zaz_(iVcRHQFz)H;6+4V&ye95&;)#-KEPi01LXJYFwNKBmvYNpi9fed78*^LZ;}&Gl zYZ2pHiN-um*a^b0rOE~5oGX*~@-<#(xhjPLm?-nrg=9iWhjZg2aqg08~gT8hSq9gK}xUA$( z)*eh1d1upQYHDgAms4S*Xff6_bflX<>mcpX=%!DPEEUAJVT%4uY%h54E;_Eyz6Q|ku*{#q$bMdoPd>IPwMNd z7p%sfQ_|!>AV~LY+p>ns;9q{%$(3AiSD4+aUA5A_PkwfoO56-L^F=Rzu6&IV`LcaF zJ$?vITKMC{?M+@RX{Zc7(s-maQTncabslk^^8;k-j95p`DiSG!Cfvxqs9SE$&efPDPsMRg+Wt^4&ome402)M?A;roaD!yFT zqu7}Iuq*$;ijNwt@dYYt-C4r61r0%cY& zh;L$VAYzo()(t%V8&@KW)$9Vz5+6y4u@8P8ru(=wy2`y#Yhp;dH2}M3f5kv(zy8m^ z0-smRn?0&D%38mBJdnZ?3G2`!RT~zS{tXUo7ly&0@jyR7L4v*R)A$c$hp9Z>o458< zxk2YfGPuph(f*3O-8Sv@`#&KOUE-m?R0A~Y|34&}NL=y!t;XyA!&`&*ccZvsgVrCk z+i~G&2&;zrYu5a0fQ>2aWZ{nZ$rcmo|BaXa!`<5UMOphd^R`ktSGWBJpQ4vTyPq^A zk}8j@L-llAN`ViK*c3E6%qD-ozv~)uF5?IIgrpb3b~#jj?x)<~wwFkbhlx;< zgO?oVL6jlaPb4oQ1z%8k8d5`BL;oX4ogNf%wJNH>F}ol>LU`>$0F|6uCBe$KxO zD!du%I+iFzB~=dE-JS^k`dW!WjISgK$-nm(sf&-0X?Onj!1Vuy?B=H;WcQ~cgq&=J znfmTGK$}lG@_EFsv^*c}EE#uh&)ocJvL~{?eu(98`8mLZXYs?dD+c;<{hKNNyUD(% zCk93C9$Tb^Ke~^fe~p>{^Fob(VA=o5k34D|Ir3=vzh3|m`8kffXC1yP&>}KQ`i;Yg~Jkc@Z?I*Ls1_^I<_m`PXT;7+wGSUtHi1W-QMtCL{ zDH6Ke#&xPEZx27Jnhg^S$=zEXDIEId6v+gx^Zg-c)kzE<*!%X#I-ip1$_cEUyM}^` z?VA*iDuc`L@G{(goQtpPCn>Q3^+4A<2HSo4C`W!h5@To!^~ztufq!UH{?7^res>>* z;j)Z0K^97@#6b02fcaXc#fv;&ms?IacZ!Dt#TCUH4IucMa*{t00q=6Rk9*Qn4N|d zdn76$!OI`C$a&)4yxDl=Pnhq|)slhdce|l|i;xtp2fD^1FF(RC{hRNroCzyW%gT&6 zlUZ?}#@`rtY^E2dr)T!;`DLa&xL+UdD5G9EiD~LfAFXo4HL=Yj2F^qnvUsA2VliyB z9F>HV5|YMn4w?FRS@A!46kI22Bj?S`@7zhbXJ8PkK=6N>OS{PKVjS^}*#1T?AX6*U zNud`zkGykqFQXTWm@;*Ys&Ydx;xmd29~j3aFTu5W3v&|g~tFyiIStSWrE zn@ZwsSJHT>x!K#ryLxtZnvW)LW@Xpb`d~R+>PzQP2lJ?aq~zrD%n+aHIDO9wz+Q8* z4OtE!retJX)O9bjDmJH%q!tzm*oh~yZc^&UQ&Sy_88`xBsTkD&^ku+rXIA>d4T@R> zN~(K(HWzXL^(`w;Spq{E#OZIC*HsiDRTgV;kCQJh;;1rSWxmLIkHvu5P5`l6E&GXr zUia4O#CG1B!C*$WZt+=`V`qYnWv_j2M&G6BD+6^q6y6dqgG|@CdW1{j)Qxq7B3D3@ zpn_5=D+~L4rS89A>~3yuIbj-i@Ahgd?*N7=o5E{!;ZI14LrR;5fpiLQ&d|_PbB|3H zWg@lFZ+pylh2rSozzu4+iBH-oGN#JN1HZdkT3YrxIy&v$$OH4tkPPh|A9v+^AEnN& z=H}6!P@aPX8Ax<$DuPN&_v7Nzbh6N{1tl<@w4K>PapWBUdNw{O12o};rWi`ah>^;Z+T|BPKj<=LpSmZf>8ZQ8a^7wD`ehNCqwEPM)Sr--t;H&d+ z#r*rWn-B<)F~mK*w>G2`Q2HC@itGAOKVnShRJ*fJuw{0)#N#q_!KO5FgEqGp8)wE_NvJ>QZ^TN%B(j%AJsOL^5sK|27o8vN-O zW%2l)vGE|`+xA;zW)-_*K0*eLkQM`Ssxl-M3BP@G^6OXg8MMiMJfQNGmle@i&>L`Z zlNKos593>GbhXN+?okBMf(qsUzS;Cvu7W#2G!$#SdPc~~g71c8A5=HR5KmvL^L zu2WT@%GQ{!GY_(pyhPd8CdtM+imu@noll06#Hj5}8oQr@K`8q|+)w*<{UT+EN>N># zTnW$@Ry|lv$n1S@+Aoz=Sh$oM>t8M7Jn9YKBYTu3$CBq+bd_91Ddz!VA_5-Yk0skD z+d6&wFg^zelS+EADabMccVG8KdMDkZ+7Nb5P&a+_jglFh#Opu)pX83bJ!vcj)tX6#6S|K(qe+oY72!v7_8KK+`XCNnz2025b6U-3v zwME9ryFa!kiDG6=2d`7ZRU-Q3AF)E%xjkDk&a$TnAMhbLdl{ddnHGTPE7XfLyjcwN zAr7F~K@$jM(x`t?e!jvZ&~r}^GdB~F=;JUk3%JxS?hg3w?68A_r_bJZ!UiA zaH=#EZbA6(?>w8TlC(>oe+(BPhliyqR#&gLMVC|ykdrzuHq`oTeplyF?#;6g0p8{r zY4P~We1CTpN`Cz|+TwB9(`k+4T*m9cCl%3lPf0LXl@q@DBN(54@%^pWOVyb6uZ*^W zz8?i8O_hNnX&c6DWHxqow$1KD3Q*HI>gtYv2(zVmaiqp|bin?z=Kfq1JPOm)la}GUs0pCkPupbp?uuV|HtVWX(>imHv1CF1Eh?lM2?LF5!dH@0*yIRQs&Y)B$g! z=ZefYSX(2P8yoBIaB$!#Fj!w-U10EJWUaCn-|I*zAvQWz*S*QbgWXSBh{fESpKqL*ZsFK~{u1SvN;V zn`dEdvAQah$l}HDJD03wPPJ@krs~N(c$59M7#`+~vqL?yc zfep#P3UaN*IsgV;0miHVfuOp*4gk+Lei;!_;zX$11Zn`F|9J?9lY+Q)BRW^QU%mv5 zhRE%YSDoMG=3aWEF&8pIkQ~-(`e!~ZGn~Q$b_3wmCNS&AZ7d8&`>h^2-eH5x&lyO# zkAEsQ1K4p#S{hw2^em4hA zHjV2n5PL`C@fDKDacvJ2AODJfba)9xH(-LyKjI>QGnpD%TwdGdZ=Gd8M zndgVuXqy%45~N26h{~6UGAU}rTD_?s7WxOkMVC0vpHC87B2ztFi>zHXkkl1~nq4kj zj@K#!zB(ak&)sbtXv zY~0>aT&Z85YC0&WZWWipH~L%8Z7HrOIi7_e)iHhFyVAtYoINv8=fYq%ENCI>+Wz|# z%yQw`sgPCNn12*za(9Z@E5GPmt#|<_j?`}h!9nj(mD45A6J9LEq?=EX?Sf0p&8Ky{ zTxI{65f1}KY&C0%nPjzkd`YqnKrHvDT#r6aZsYa)xGn(KKn@P{D?UCR#e(VE)x8({ zpuBpAbMoPJhzZw-USiXuZO7n~a^qa0nPx{v_I#(LCV5wDj zCs!aa@m~5?Dh(Q?l#Dx%-3^e!tQ`Ggdbrej-5VKyK7hR|E-tW9;Yxui%TAoOXQO2-n^0~Kw#kR9=7!-i?wBFy5U86tgIEqal zD|Ivr2C6t9rTSpxVyYy3j?<8@)0t_sVkH(+q>VTjaa|tOGu1EgWT3T8JAuUL4>8p@ z5AHm{dTh+$hFL`vR#-J3>z6olCIVQxBSliuLyZdd5m9UlE8Qof2(q4c>qd%lOINR% z+s=$cK7T&^1_UEx;}QC%u(sPFq}Lymb<%En#;n2Sw-S)uUN$t;rlrz%fE>0VbE0w-h&Oj$ua*d1mQOKy zxOHs^&^E;4qLA~#^uT5!D@aenU*Ox?YOW~gZ^fP+*M4>t0rX=rEq^MfFET>dPeZV6 zH5UC+H$p;`+_nl`|0DQ%-^5Q;$nNF{H%f?Mb4m^ zsfCsDyq{w4&ScedOiDk}_4`lNdcvm=0->LM8*ukxB6xk6jD zU{lU&QdK?k+Q{X^9%@UamJ2wsK}URIr$^J%>09X*=W?>O63jG2e|T;#3~J{7)-mw> z$jQ2bf&w+%<~9wo@KuvHHs0~+2hvJf6|EWTFkj!@z6@ZtWiG{lvJbUBmEF!feJANf zb6$oOnl~Mcy04&45(p93!ItqUxN;e&`*gKQrF@Q0um^!gW? zV`5Zu!N#55-&-p6!F@jbRW!*_{jk4U>!LhZ0aJb1@O{7|F9Hl->PHD>2Y4Xb&mUwU znzIH-Balc-@n&@%^xSZnF=^a;f(i=*Bnonc9mvR*-5HG>91CnKYVfce$Jz1m0bS+u zZwm^n<<2~9RZ6$DqY-)$kpe#uZY~3QPsr8T*Y*V%6F#!39vY6GbK2xmrZpAysn zHPSjn3riZG*>#VukBxo0Bef9b3)JMa&Ou!r>#+n;<#c(&H0)g#E9HZ2avG2{du}cD zXDNTQDyePjSdPUfE+k_tt6l)jUs9)sd6kplZgbGF*Fc3QLj4}Z^c)C^*}-?PgkUfr z^$A@RJQ%L-~^V*?Lm`fKq+MeV`|)?` zKmRamd&o9tn$5(?FECDLc)j|sX!qOa#9?wrttSnv05^3NWg zzhm=WLF!c6*H3iDD!-YYMumijGkrXyH*mW2MYiZ+r`Pw@3^bZEUS8CO%KC3veYj^B zImy>mete3|vA>~{yNe2?qS4ggCsjTY?~#6@%7Mg+^yZE3>|8tLBPB#FpGXP*JT| zqD|*FzT^+2p{Sccco*P@w6e0FrL0GNQOH#lp1JrcU2tD?4aNS-=XlFx(nFlP(19iIax|Z2GGF)< zCtaWr>7GgX(X7HE{{!Fjf{p!!P2CjovcEps*ULuq#c728ihp1IDV}7IF%+mh@5;uJ zSf3Jf2rJX=DWteKF{BWyImUG~oRKNltziv(xAS`;-`r^ghVg);0v5WyvFK0W7#NYX zO^+BmI}9?9@62x});6{}~4y^e4qv!t(_=Ykz From 16c2f9043238aac373cb23d4eeee4082e6a008a5 Mon Sep 17 00:00:00 2001 From: Aaron Clarke Date: Thu, 13 Jun 2019 16:11:45 -0700 Subject: [PATCH 5/5] Updated persistent cache docstring. --- shell/common/persistent_cache.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/shell/common/persistent_cache.h b/shell/common/persistent_cache.h index ce2a1044d5fed..4c7d65d95b15c 100644 --- a/shell/common/persistent_cache.h +++ b/shell/common/persistent_cache.h @@ -17,7 +17,9 @@ namespace flutter { -/// A cache of shaders that gets stored to disk. +/// A cache of SkData that gets stored to disk. +/// +/// This is mainly used for Shaders but is also written to by Dart. class PersistentCache : public GrContextOptions::PersistentCache { public: // Mutable static switch that can be set before GetCacheForProcess. If true,