From 23dab591016e2b2f3cc2c9837d1b9e48a470da12 Mon Sep 17 00:00:00 2001 From: Stuart Morgan Date: Sat, 6 Jul 2019 06:50:19 -0700 Subject: [PATCH] Check for null response_handle in FlutterEngineSendPlatformMessage PR #9655 allows for providing a response handle when sending messages into the Flutter engine, but didn't check for a null response handle; this crashes all existing embedders that use FlutterEngineSendPlatformMessage. --- shell/platform/embedder/embedder.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/shell/platform/embedder/embedder.cc b/shell/platform/embedder/embedder.cc index 11c05c86dad0d..fcce64bad2c3e 100644 --- a/shell/platform/embedder/embedder.cc +++ b/shell/platform/embedder/embedder.cc @@ -823,7 +823,7 @@ FlutterEngineResult FlutterEngineSendPlatformMessage( SAFE_ACCESS(flutter_message, response_handle, nullptr); fml::RefPtr response; - if (response_handle->message) { + if (response_handle && response_handle->message) { response = response_handle->message->response(); }