From db6b51acd34effbf570a2ed0a6676c1ac631ac54 Mon Sep 17 00:00:00 2001 From: Ian Hickson Date: Mon, 14 Aug 2023 14:14:56 -0700 Subject: [PATCH 1/2] Add advice on code review for this repo --- CONTRIBUTING.md | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 1af21ea62c5d..90faf9d08ccc 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -18,7 +18,20 @@ Additional resources specific to the packages repository: [**PRs need tests**](https://github.com/flutter/flutter/wiki/Tree-hygiene#tests), so this is critical to read before submitting a plugin PR. -## Notes +### Code review processes and automation + +Each package has a code owner (specified in +[CODEOWNERS](https://github.com/flutter/packages/blob/main/CODEOWNERS)); +PRs will automatically be assigned to the appropriate code owners for review. +Review is expected within a week or two (but preferred much quicker than that!). + +Code owners need to explicitly pick a +[Flutter team member](https://github.com/flutter/flutter/wiki/Contributor-access) +as their code reviewer for PRs that affect their package, +usually someone who has contributed to the package before. + +For help, join the `#hackers-ecosystem` channel on our +[Discord server](https://github.com/flutter/flutter/wiki/Chat). ### Style From 20b35c01f54546369fb0353c7e4467f647a6e630 Mon Sep 17 00:00:00 2001 From: Ian Hickson Date: Tue, 15 Aug 2023 09:38:38 -0700 Subject: [PATCH 2/2] Update CONTRIBUTING.md --- CONTRIBUTING.md | 16 +++++----------- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 90faf9d08ccc..ce9b0e6fe842 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -20,18 +20,12 @@ Additional resources specific to the packages repository: ### Code review processes and automation -Each package has a code owner (specified in -[CODEOWNERS](https://github.com/flutter/packages/blob/main/CODEOWNERS)); -PRs will automatically be assigned to the appropriate code owners for review. -Review is expected within a week or two (but preferred much quicker than that!). - -Code owners need to explicitly pick a +PRs will automatically be assigned to +[code owners](https://github.com/flutter/packages/blob/main/CODEOWNERS) +for review. +If a code owner is creating a PR, they should explicitly pick another [Flutter team member](https://github.com/flutter/flutter/wiki/Contributor-access) -as their code reviewer for PRs that affect their package, -usually someone who has contributed to the package before. - -For help, join the `#hackers-ecosystem` channel on our -[Discord server](https://github.com/flutter/flutter/wiki/Chat). +as a code reviewer. ### Style