From 6f85e069d545c3f6eb1c5a5324007a71401c56a8 Mon Sep 17 00:00:00 2001 From: ianko Date: Thu, 2 May 2019 16:20:02 -0400 Subject: [PATCH 1/2] Fix race condition on disposing the VideoController. --- packages/video_player/CHANGELOG.md | 5 +++++ packages/video_player/lib/video_player.dart | 4 ++++ packages/video_player/pubspec.yaml | 2 +- 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/packages/video_player/CHANGELOG.md b/packages/video_player/CHANGELOG.md index e3e9d9d01691..1584fcbb0db8 100644 --- a/packages/video_player/CHANGELOG.md +++ b/packages/video_player/CHANGELOG.md @@ -1,3 +1,8 @@ +## 0.10.0+9 + +* Fix race condition while disposing the VideoController. + + ## 0.10.0+8 * iOS: Fix an issue where the player sends initialization message incorrectly. diff --git a/packages/video_player/lib/video_player.dart b/packages/video_player/lib/video_player.dart index ce4ac70cff43..80d78a7c4633 100644 --- a/packages/video_player/lib/video_player.dart +++ b/packages/video_player/lib/video_player.dart @@ -228,6 +228,10 @@ class VideoPlayerController extends ValueNotifier { } void eventListener(dynamic event) { + if (_isDisposed) { + return; + } + final Map map = event; switch (map['event']) { case 'initialized': diff --git a/packages/video_player/pubspec.yaml b/packages/video_player/pubspec.yaml index e469a120afa1..9959d5ef4033 100644 --- a/packages/video_player/pubspec.yaml +++ b/packages/video_player/pubspec.yaml @@ -2,7 +2,7 @@ name: video_player description: Flutter plugin for displaying inline video with other Flutter widgets on Android and iOS. author: Flutter Team -version: 0.10.0+8 +version: 0.10.0+9 homepage: https://github.com/flutter/plugins/tree/master/packages/video_player flutter: From 5cc515a1c802a77d3992b9da33d5a9309a5ccc0a Mon Sep 17 00:00:00 2001 From: Chris Yang Date: Thu, 18 Jul 2019 12:48:35 -0700 Subject: [PATCH 2/2] Update pubspec.yaml --- packages/video_player/pubspec.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/video_player/pubspec.yaml b/packages/video_player/pubspec.yaml index dd5d0b5a75f5..bbb2dcda02ef 100644 --- a/packages/video_player/pubspec.yaml +++ b/packages/video_player/pubspec.yaml @@ -2,7 +2,7 @@ name: video_player description: Flutter plugin for displaying inline video with other Flutter widgets on Android and iOS. author: Flutter Team -version: 0.10.1+4 +version: 0.10.1+5 homepage: https://github.com/flutter/plugins/tree/master/packages/video_player flutter: