From 7c408206afa90214d163623fca768502bc8798aa Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Linus=20Unneb=C3=A4ck?= Date: Fri, 17 May 2019 11:32:36 +0100 Subject: [PATCH 1/3] [url_launcher] avoid deprecation warning in guarded code The `[application openURL:]` was deprecated in iOS 10. Since we are already using the newer API on iOS 10 and newer, this warning can be safely ignored. Avoids the following output when building a flutter app that uses this plugin: ``` url_launcher-5.0.2/ios/Classes/UrlLauncherPlugin.m:141:33: warning: 'openURL:' is deprecated: first deprecated in iOS 10.0 - Please use openURL:options:completionHandler: instead [-Wdeprecated-declarations] BOOL success = [application openURL:url]; ^ In module 'UIKit' imported from /Users/linus/coding/eego/ios/Pods/Target Support Files/url_launcher/url_launcher-prefix.pch:2: /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS12.2.sdk/System/Library/Frameworks/UIKit.framework/Headers/UIApplication.h:128:1: note: 'openURL:' has been explicitly marked deprecated here - (BOOL)openURL:(NSURL*)url NS_DEPRECATED_IOS(2_0, 10_0, "Please use openURL:options:completionHandler: instead") NS_EXTENSION_UNAVAILABLE_IOS(""); ^ 3 warnings generated. ``` --- packages/url_launcher/ios/Classes/UrlLauncherPlugin.m | 3 +++ 1 file changed, 3 insertions(+) diff --git a/packages/url_launcher/ios/Classes/UrlLauncherPlugin.m b/packages/url_launcher/ios/Classes/UrlLauncherPlugin.m index 2136df1bf784..56681dcd1ee3 100644 --- a/packages/url_launcher/ios/Classes/UrlLauncherPlugin.m +++ b/packages/url_launcher/ios/Classes/UrlLauncherPlugin.m @@ -138,7 +138,10 @@ - (void)launchURL:(NSString *)urlString result(@(success)); }]; } else { +#pragma clang diagnostic push +#pragma clang diagnostic ignored "-Wdeprecated-declarations" BOOL success = [application openURL:url]; +#pragma clang diagnostic pop result(@(success)); } } From edf78a9a4367bae4aa94c35cd03e31c06a66cbdb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Linus=20Unneb=C3=A4ck?= Date: Fri, 17 May 2019 11:36:48 +0100 Subject: [PATCH 2/3] [url_launcher] cut new release 5.0.2+1 --- packages/url_launcher/CHANGELOG.md | 3 +++ packages/url_launcher/pubspec.yaml | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/packages/url_launcher/CHANGELOG.md b/packages/url_launcher/CHANGELOG.md index 7f4e90c0fc9a..c77f3ff69835 100644 --- a/packages/url_launcher/CHANGELOG.md +++ b/packages/url_launcher/CHANGELOG.md @@ -1,3 +1,6 @@ +## 5.0.2+1 +* Suppress a handled deprecation warning on iOS + ## 5.0.2 * Fixes `closeWebView` failure on iOS. diff --git a/packages/url_launcher/pubspec.yaml b/packages/url_launcher/pubspec.yaml index 6845650be0a7..448d4de4bd31 100644 --- a/packages/url_launcher/pubspec.yaml +++ b/packages/url_launcher/pubspec.yaml @@ -3,7 +3,7 @@ description: Flutter plugin for launching a URL on Android and iOS. Supports web, phone, SMS, and email schemes. author: Flutter Team homepage: https://github.com/flutter/plugins/tree/master/packages/url_launcher -version: 5.0.2 +version: 5.0.2+1 flutter: plugin: From f5fc8dfa1b671143b7c7579d85330ec03e2d01b0 Mon Sep 17 00:00:00 2001 From: Michael Klimushyn Date: Thu, 25 Jul 2019 13:25:23 -0700 Subject: [PATCH 3/3] Update patch version correctly Whoops. Pub switches its semver scheme from 0.x.y+z to x.y.z depending on whether or not a package is above or below 1.0.0. --- packages/url_launcher/CHANGELOG.md | 2 +- packages/url_launcher/pubspec.yaml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/url_launcher/CHANGELOG.md b/packages/url_launcher/CHANGELOG.md index 43cbb1454afc..d4d785eeccb0 100644 --- a/packages/url_launcher/CHANGELOG.md +++ b/packages/url_launcher/CHANGELOG.md @@ -1,4 +1,4 @@ -## 5.1.0+1 +## 5.1.1 * Suppress a handled deprecation warning on iOS diff --git a/packages/url_launcher/pubspec.yaml b/packages/url_launcher/pubspec.yaml index f7b858211d3a..71a94f9e565c 100644 --- a/packages/url_launcher/pubspec.yaml +++ b/packages/url_launcher/pubspec.yaml @@ -3,7 +3,7 @@ description: Flutter plugin for launching a URL on Android and iOS. Supports web, phone, SMS, and email schemes. author: Flutter Team homepage: https://github.com/flutter/plugins/tree/master/packages/url_launcher -version: 5.1.0+1 +version: 5.1.1 flutter: plugin: